Repository navigation
refactor(lumina): extract shared index components - #383
Merged
Merged
Conversation
…refactor # Conflicts: # src/paimon/global_index/lumina/lumina_global_index.cpp # src/paimon/indexer/lumina/CMakeLists.txt # src/paimon/indexer/lumina/lumina_checkpoint_manager.cpp # src/paimon/indexer/lumina/lumina_checkpoint_manager.h # src/paimon/indexer/lumina/lumina_global_index.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #361
Move the Lumina plugin from
src/paimon/global_index/luminatosrc/paimon/indexer/luminaand separate the Global Index adapter from the Lumina-specific reusable components.This change extracts the shared dataset, index accumulator, option parsing, tag conversion, and search lifecycle code.
LuminaIndexSearcherowns the opened native searcher and its extensions, performs vector-search dispatch, and closes the native searcher through RAII. The existing Lumina Global Index behavior remains unchanged.This PR does not add a Lumina File Index implementation or change the Paimon File Index and Global Index framework APIs.
Tests
cmake --build build --target paimon-lumina-index-test -j 16./build/debug/paimon-lumina-index-test --gtest_brief=1(22 tests passed)pre-commit run --files <changed files>git diff --checkAPI and Format
No public API, storage format, or protocol changes.
Documentation
No user-facing feature or documentation change.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-5)