NIFI-16099: Controller Service Provider should be passed to Connectors

[bobpaulin]

Summary

NIFI-16099

StandardFlowManager.createConnector builds the connector via ExtensionBuilder, but the builder chain is missing the

.controllerServiceProvider(...)

every other builder in the same file uses this call.

Compare with, for example, buildProcessorNode, buildControllerServiceNode, buildReportingTaskNode, buildFlowAnalysisRuleNode, buildFlowRegistryClient — every one of them calls: .controllerServiceProvider(flowController.getControllerServiceProvider()).

ExtensionBuilder.buildConnector(...) also doesn't requireNonNull(serviceProvider, ...) (unlike every other builder in the file), so the null slips silently into the StandardConnectorNode constructor.

This is required for the connector code to use the ControllerServiceProvider which will be required for Migrations. SEE #11240

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
• Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using ./mvnw clean install -P contrib-check
  • JDK 21
  • JDK 25

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[markap14]

Good catch @bobpaulin ! Thanks for the fix. +1 will merge