Skip to content

revise mavenskeleton + try dependency check - #9601

Open
ebarboni wants to merge 1 commit into
masterfrom
depversions
Open

revise mavenskeleton + try dependency check#9601
ebarboni wants to merge 1 commit into
masterfrom
depversions

Conversation

@ebarboni

@ebarboni ebarboni commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Attempt to make the maven skeleton a bit more hierachical to match cluster and module name.

ant verify-libs-and-licenses is used to make skeleton on nbbuild/build/mavenpoms

mvn eu.maveniverse.maven.plugins:toolbox:0.15.17:dependency-versions can be launched on the folder root or in subfolder cluster to reduce scope.

@ebarboni ebarboni added this to the NB32 milestone Sep 4, 2026
@ebarboni
ebarboni requested a review from mbien September 4, 2026 13:48
@ebarboni ebarboni added Upgrade Library Library (Dependency) Upgrade CI continuous integration changes labels Sep 4, 2026

@mbien mbien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is the better approach. Initially I did the exact same and generated poms - I can't really remember why I ended up using the API via a script.

Feel free to remove the old workflow with the same commit to keep things clean.

- name: Check Dependencies
run: |
ant -quiet bootstrap
ant -quiet verify-libs-and-license

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

licenses

run: |
ant -quiet bootstrap
ant -quiet verify-libs-and-license
cd nbbuild/build/mavenpoms/;mvn eu.maveniverse.maven.plugins:toolbox:0.15.17:dependency-versions

@mbien mbien Sep 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: split line

          cd nbbuild/build/mavenpoms/
          mvn -B eu.maveniverse.maven.plugins:toolbox:0.15.17:libyear

btw, how about running libyear instead of dependency-versions?

difference: it will print less (won't show "up to date" lines) and it calculates age too, which can be useful for prioritization.

This is the most concice output I could come up with:

mvn -B\
 -Dorg.slf4j.simpleLogger.defaultLogLevel=warn\
 -Dorg.slf4j.simpleLogger.log.eu.maveniverse.maven=info\
 -DupToDate=true\
 eu.maveniverse.maven.plugins:0.15.17:toolbox:libyear

generates about 1200 lines.

I am not sure what the github limit is. Would be cool if we could post it there like the other action.

          echo "<pre>" >> $GITHUB_STEP_SUMMARY
          <command> | tee -a $GITHUB_STEP_SUMMARY
          echo "</pre>" >> $GITHUB_STEP_SUMMARY

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice. apparently github limits at 1MB - this will fit without problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI continuous integration changes Upgrade Library Library (Dependency) Upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants