Stabilize ClassIndexTest#testQueryIndexRefreshQueryAgain - #9600
Merged
Conversation
swap waitScanFinished() with refreshAllIndices() and added some debug print for the indexer state.
lahodaj
approved these changes
Sep 4, 2026
lahodaj
left a comment
Contributor
There was a problem hiding this comment.
I don't think this order affects the validity of the test, so improving stability is definitely good. Thanks!
Member
Author
|
we can remove the pritnlns next time the tests are cleaned up. Maybe they give use useful info in case it starts failing again. Thanks for checking -> merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swap
waitScanFinished()withrefreshAllIndices()and added some debug print for the indexer state.100x test loop worked https://github.com/mbien/netbeans/actions/runs/33841946719 (local testrun with the same iteration count passed too)
@lahodaj is the test case still working as intended after the two methods are swapped?
issue #8183 (comment)