Skip to content

Stabilize ClassIndexTest#testQueryIndexRefreshQueryAgain - #9600

Merged
mbien merged 1 commit into
apache:masterfrom
mbien:stabilize-classindex-test
Sep 4, 2026
Merged

Stabilize ClassIndexTest#testQueryIndexRefreshQueryAgain#9600
mbien merged 1 commit into
apache:masterfrom
mbien:stabilize-classindex-test

Conversation

@mbien

@mbien mbien commented Sep 4, 2026

Copy link
Copy Markdown
Member

swap waitScanFinished() with refreshAllIndices() and added some debug print for the indexer state.

100x test loop worked https://github.com/mbien/netbeans/actions/runs/33841946719 (local testrun with the same iteration count passed too)

@lahodaj is the test case still working as intended after the two methods are swapped?

issue #8183 (comment)

swap waitScanFinished() with refreshAllIndices() and added some debug
print for the indexer state.
@mbien mbien added this to the NB32 milestone Sep 4, 2026
@mbien
mbien requested a review from lahodaj September 4, 2026 06:25
@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) CI continuous integration changes tests labels Sep 4, 2026

@lahodaj lahodaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this order affects the validity of the test, so improving stability is definitely good. Thanks!

@mbien

mbien commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

we can remove the pritnlns next time the tests are cleaned up. Maybe they give use useful info in case it starts failing again. Thanks for checking -> merging.

@mbien
mbien merged commit b0739f7 into apache:master Sep 4, 2026
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI continuous integration changes Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants