Skip to content

Fix search preview editor mime type on JDK 27#9522

Open
mbien wants to merge 1 commit into
apache:deliveryfrom
mbien:fix-search-preview-mime-type-on-jdk27
Open

Fix search preview editor mime type on JDK 27#9522
mbien wants to merge 1 commit into
apache:deliveryfrom
mbien:fix-search-preview-mime-type-on-jdk27

Conversation

@mbien

@mbien mbien commented Jul 17, 2026

Copy link
Copy Markdown
Member

mime types can't be set by String atm since the mime type injection hack doesn't work anymore. Set it by editor kit, similar other code does it (previews in bookmarks view, refactoring view. diffs etc - they all still work on JDK 27).

repro: use right click search and/or replace and look at preview, the editor should not be plain text

edit: this is for delivery, we can cleanup AppContext usages for NB 32 #9523

@mbien mbien added this to the NB31 milestone Jul 17, 2026
@mbien mbien added Editor ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 17, 2026
mime types can't be set by String atm since the mime type injection
hack doesn't work anymore. Set it by editor kit, similar other code
does it (previews in bookmarks view, refactoring view. diffs etc).
@mbien
mbien force-pushed the fix-search-preview-mime-type-on-jdk27 branch from 974ee23 to f5aa6ef Compare July 17, 2026 10:55

@neilcsmith-net neilcsmith-net left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants