JSF: skip looking for managed/named beans on incompatible JSF versions#9489
Open
NicolaIsotta wants to merge 1 commit into
Open
JSF: skip looking for managed/named beans on incompatible JSF versions#9489NicolaIsotta wants to merge 1 commit into
NicolaIsotta wants to merge 1 commit into
Conversation
- do not search CDI Named beans on JSF 2.1- (CDI support was introduced in 2.2) - do not search managed beans on Faces 4.0 or upper since support was removed small code refactors/modernization
Contributor
Author
|
Just a note: the current behavior doesn't actually cause errors or exceptions - the main purpose of the PR is performance |
Member
|
@NicolaIsotta this looks like a small change and I suppose you tested it. If you want we could try merging this for NB 31 if you rebase it soon (till Wednesday) |
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
@NicolaIsotta I'm wondering about the statements, that check for the JSF version. The current implementation is mixed in regard to beans to be not shown if the version can't be determined:
JsfELVariableResolverreturn beans based onui:paramif version can't be determinedWebBeansELVariableResolverdoes not return beans if version can't be determinedJSFBeanCachedoes not return beans if version can't be determined.
Would it make sense to unify this?!
Contributor
Author
|
Makes sense, I'll align the behaviors BTW: this is just a small performance improvement, I think it can safely wait NB32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small code refactors/modernization
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
LLMs, Commit messages and PR description:
git log) that all commits have a valid name and email address for you in the Author field.Assisted-by: MODEL_NAME MODEL_VERSIONline appended to the commit message.Assisted-byline from above)If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)