Skip to content

JSF: skip looking for managed/named beans on incompatible JSF versions#9489

Open
NicolaIsotta wants to merge 1 commit into
apache:masterfrom
NicolaIsotta:skip-managed-beans
Open

JSF: skip looking for managed/named beans on incompatible JSF versions#9489
NicolaIsotta wants to merge 1 commit into
apache:masterfrom
NicolaIsotta:skip-managed-beans

Conversation

@NicolaIsotta

@NicolaIsotta NicolaIsotta commented Jul 7, 2026

Copy link
Copy Markdown
Contributor
  • do not search CDI Named beans on JSF 2.1- (CDI support was introduced in 2.2)
  • do not search managed beans on Faces 4.0 or upper since support was removed

small code refactors/modernization


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

LLMs, Commit messages and PR description:

  • Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.
  • LLM assisted commits should be attributed with an Assisted-by: MODEL_NAME MODEL_VERSION line appended to the commit message.
    • Please mention coding assistance in the PR description too (eg. by adding the same Assisted-by line from above)
    • Please describe the changes in your own words - we'd like to know you understand the changes being made!

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

- do not search CDI Named beans on JSF 2.1- (CDI support was introduced in 2.2)
- do not search managed beans on Faces 4.0 or upper since support was removed

small code refactors/modernization
@mbien mbien added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 7, 2026
@apache apache locked and limited conversation to collaborators Jul 7, 2026
@apache apache unlocked this conversation Jul 7, 2026
@NicolaIsotta

Copy link
Copy Markdown
Contributor Author

Just a note: the current behavior doesn't actually cause errors or exceptions - the main purpose of the PR is performance

@mbien mbien added this to the NB31 milestone Jul 13, 2026
@mbien

mbien commented Jul 13, 2026

Copy link
Copy Markdown
Member

@NicolaIsotta this looks like a small change and I suppose you tested it. If you want we could try merging this for NB 31 if you rebase it soon (till Wednesday)

@matthiasblaesing matthiasblaesing left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicolaIsotta I'm wondering about the statements, that check for the JSF version. The current implementation is mixed in regard to beans to be not shown if the version can't be determined:

  • JsfELVariableResolver return beans based on ui:param if version can't be determined
  • WebBeansELVariableResolver does not return beans if version can't be determined
  • JSFBeanCache does not return beans if version can't be determined.

Would it make sense to unify this?!

@NicolaIsotta

Copy link
Copy Markdown
Contributor Author

Makes sense, I'll align the behaviors

BTW: this is just a small performance improvement, I think it can safely wait NB32

@mbien mbien modified the milestones: NB31, NB32 Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants