CDI: improve PackagingFilter performance by avoiding costly opeation in loop#9381
Merged
matthiasblaesing merged 1 commit intoMay 13, 2026
Merged
Conversation
matthiasblaesing
added
Java EE/Jakarta EE
matthiasblaesing
approved these changes
May 8, 2026
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Change looks sane to me. Thank you!
Contributor
|
I intent to merge this sometime next week unless there are objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered this bottleneck while working on other things.
The current version recreates the ClasspathInfo every iteration of the loop, causing a remarkable slowdown; this PR introduces a lazily-inizialized resusable ClasspathInfo.
In one of my test cases (
@Injecton ajava.util.Map), the boost was ≃ 10x (time spent in the method went down from 2 secs to less than 200 millis).