Enhance LSP client to support configuring language ID and add support for Typescript React#9238
Open
matthiasblaesing wants to merge 2 commits intoapache:masterfrom
Open
Enhance LSP client to support configuring language ID and add support for Typescript React#9238matthiasblaesing wants to merge 2 commits intoapache:masterfrom
matthiasblaesing wants to merge 2 commits intoapache:masterfrom
Conversation
matthiasblaesing
added
LSP
Contributor
Author
|
@lahodaj would you please have a look at the implementation/the new API added to support mapping language ids? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In contrast to NetBeans LSP servers don't use the mimetype of the file to determine their support or the variant to use for the file.
One such example is the typescript LSP server, that offers support for:
the client has to provide the correct language id or it uses the default (typescript).
This changeset adds the option to configure the language id to use for generic LSP support and it updates the typescript LSP integration to support both typescript (for .ts files) and typescriptreact (for .tsx files). The typescript enhancement allows for code completion inside TSX elements.