Merged
Conversation
mbien
added
CI
Member
|
Thanks for looking at this. Looks good, assuming artifact upload doesn't require permissions? |
Member
Author
|
upload/download/delete to/from workflow storage doesn't require one as far as I know. Cache migrates around so it needs write permission. |
Member
Author
|
I tested it in the master branch of my fork too, but forks have also slightly different rules so I am not sure how representative that test run is: https://github.com/mbien/netbeans/actions/runs/22361486268 |
neilcsmith-net
approved these changes
Feb 24, 2026
Member
neilcsmith-net
left a comment
neilcsmith-net
left a comment
There was a problem hiding this comment.
Thanks. Just checking - seems curious it doesn't need a permission. Let's see if anything breaks! 😄
Member
Author
|
one thing i have to test with a PR if the expression language needs permissions for reading the PR labels etc. Going to rebase #9217 and tell it to upload a dev build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the workflows were intentionally made to require no noteworthy permissions, this locks it in place.
note: unfortunately this can't be tested before its in master, since the workflow run in this PR would still use the org permissions (even though the log will state otherwise).