Skip to content

[GITHUB-9182] Fixing code completion for record component types.#9225

Merged
lahodaj merged 1 commit intoapache:masterfrom
lahodaj:GITHUB-9182
Feb 25, 2026
Merged

[GITHUB-9182] Fixing code completion for record component types.#9225
lahodaj merged 1 commit intoapache:masterfrom
lahodaj:GITHUB-9182

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Feb 24, 2026

Removing code that does not make sense to me. As I read the code, it seems the removed code is not really needed, and the code below can handle the cases well enough. I may be mistaken, of course.

closes #9182


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@lahodaj lahodaj added this to the NB30 milestone Feb 24, 2026
@lahodaj lahodaj added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Feb 24, 2026
@mbien mbien linked an issue Feb 24, 2026 that may be closed by this pull request
@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Feb 24, 2026
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, thanks!

edit: fixes which remove code are my favorite :)

@lahodaj
Copy link
Contributor Author

lahodaj commented Feb 25, 2026

edit: fixes which remove code are my favorite :)

Mine as well :-)

@lahodaj lahodaj merged commit 24ecfb3 into apache:master Feb 25, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code completion for class names is broken in record component list

2 participants