Remove duplicate assertion in testFileWilcards - #13165
Merged
gnodet merged 1 commit intoSep 17, 2026
Merged
Conversation
gnodet-bot
approved these changes
Sep 17, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
The removal is correct. The deleted assertion is byte-for-byte identical to line 424 — same expression, same context, no semantic difference. After the deletion the method retains 4 positive assertions and 2 negative assertions, so coverage is unchanged.
Minor note: the PR description says "Already fixed on maven-4.0.x in #13163 (475f726)" — #13163 is still open as of this review, not yet merged, so that phrasing is slightly ahead of reality. No action needed here.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13160: remove the duplicate
assertActivation(true, newProfile("exists('${project.basedir}/**/*.xsd')"), newFileContext())line carried over from the pre-existing@Disabledblock. Already fixed onmaven-4.0.xin #13163 (475f726).