Fix stale Javadoc and GAV typo in external-profile tests (follow-up to #13141) - #13156
Merged
Merged
Conversation
- DefaultModelBuilderTest: update resolvedProfilesRequest() Javadoc (stale 'contribute no repositories'); fix active-by-default-profile resolvedSource GAV (org.apache.maven.test, matching fixture and existing test convention) - active-by-default-profile.xml: fix groupId plural→singular to match the rest of the poms/factory fixtures and the test coordinate hint Found during review of apache#13155.
gnodet
added
documentation
gnodet-bot
suggested changes
Sep 17, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
The Javadoc update to resolvedProfilesRequest() is accurate and well-worded. The POM fixture fix (removing the errant s: org.apache.maven.tests → org.apache.maven.test) is correct.
However the corresponding change to the test's resolvedSource GAV goes in the wrong direction — see inline.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
gnodet-bot
approved these changes
Sep 17, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
Previous finding addressed: commit 5764d1b8 correctly reverts the resolvedSource GAV to org.apache.maven.test (no s), consistent with all other call sites in the class.
The two remaining changes are clean:
resolvedProfilesRequest()Javadoc accurately reflects the current behavior (repositories from legitimately-active JDK/OS/activeByDefaultprofiles are honored atCONSUMER_DEPENDENCYlevel, as implemented in #13100)active-by-default-profile.xmlgroupIdfix (org.apache.maven.tests→org.apache.maven.test) aligns the fixture with the test coordinates
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13141, fixing three issues found during review of #13155.
DefaultModelBuilderTest: updateresolvedProfilesRequest()Javadoc — the sentence "their profiles contribute no repositories" is now false for JDK/OS/activeByDefault-activated profiles; fixactive-by-default-profileresolvedSourceGAV typo (org.apache.maven.test, matching the fixture and existing test convention)active-by-default-profile.xml: fixgroupIdplural → singular (org.apache.maven.test) to match the rest of thepoms/factory/fixtures and the test coordinate hintExternalModelProfileActivationTest(compat): update class-level Javadoc — same stale sentence