Fix default-bindings doc snippet to reference PluginVersions - #13140
Merged
gnodet merged 1 commit intoSep 15, 2026
Merged
Conversation
…AbstractLifecycleMappingProvider The 'versions' snippet in default-bindings.md.vm was referencing AbstractLifecycleMappingProvider.java, which no longer contains the version constants after the backport of apache#13080. Point it to PluginVersions.java and add the required START/END SNIPPET markers.
gnodet-bot
approved these changes
Sep 15, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
Minimal, correct fix. AbstractLifecycleMappingProvider on maven-4.0.x no longer carries the version constants after #13137, so the snippet macro was broken. Adding // START SNIPPET: versions / // END SNIPPET: versions markers to PluginVersions.java and redirecting the macro reference is the right approach, consistent with how the master branch (#13138) handles it.
No logic change — just comment markers and a path update.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13137.
The
default-bindings.md.vmdoc page uses aMACRO{snippet|id=versions|...}to render the plugin version constants. It was pointing atAbstractLifecycleMappingProvider.java, which no longer contains those constants after #13137 removed them.Fix:
// START SNIPPET: versions/// END SNIPPET: versionsmarkers toPluginVersions.javadefault-bindings.md.vmto point toPluginVersions.javaThe same fix is included in #13138 for master.