Fix BOM version resolution for sibling modules in dependencyManagement#12416
Open
Hiteshsai007 wants to merge 3 commits into
Open
Fix BOM version resolution for sibling modules in dependencyManagement#12416Hiteshsai007 wants to merge 3 commits into
Hiteshsai007 wants to merge 3 commits into
Conversation
elharo
requested changes
Jul 5, 2026
elharo
left a comment
Contributor
There was a problem hiding this comment.
- Needs tests
- Needs a link to github issue
Contributor
Author
|
@elharo Thanks for the review! I've addressed both items:
All 13 tests in |
elharo
requested changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses, fixing a regression in Maven 4 where version and
groupIdinference were skipped for dependencies declared within the<dependencyManagement>section of a BOM-packaged project.Issue: #11147
How it works:
I updated the
transformFileToRawmethod withinDefaultModelBuilderto ensure thatmodel.getDependencyManagement().getDependencies()is processed with the sameinferDependencyVersionandinferDependencyGroupIdlogic that is already applied to direct dependencies (model.getDependencies()).Why this is necessary:
Previously, if a BOM subproject declared sibling reactor modules within its
<dependencyManagement>block but omitted the<version>tags (expecting them to be resolved from the reactor), the transformation to the raw model would skip them entirely. This resulted in the installed consumer POM missing the required version tags for those managed dependencies. This change ensures that the reactor versions are properly inherited and written to the consumer POM.Testing:
bom-examplereproducer provided in the issue, confirming that the resulting consumer POM now contains the correctly inferred versions.spotless:applyand successfully passed allmaven-implunit tests. Note: Due to the complexity of simulating a full multi-module reactor state directly withinDefaultModelBuilderTest, a standalone unit test for this specific code path was omitted in favor of the reproducer validation.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.