Fix #12080: mvnup - comment out dependencies with undefined property expressions#12083
Open
gnodet wants to merge 1 commit into
Open
Fix #12080: mvnup - comment out dependencies with undefined property expressions#12083gnodet wants to merge 1 commit into
gnodet wants to merge 1 commit into
Conversation
This was referenced May 18, 2026
gnodet
force-pushed
the
fix-12080-comment-undefined-property-deps
branch
from
376f1ef to
b7e2f64
Compare
…expressions
Add a new compatibility fix to CompatibilityFixStrategy that detects
dependencies whose coordinate fields (groupId, artifactId, version)
contain ${...} expressions referencing properties not defined in any
project POM. These orphan dependencies cause Maven 4's validator to
reject them with "Not fully interpolated dependency" errors.
The fix collects all properties from <properties> sections across the
reactor (including profiles), skips well-known built-in properties
(project.*, env.*, settings.*, maven.*, revision, sha1, changelist,
etc.), and comments out dependencies with truly undefined expressions
using <!-- mvnup: commented out - undefined property '...' --> format.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
fix-12080-comment-undefined-property-deps
branch
from
b7e2f64 to
d85775a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompatibilityFixStrategythat comments out dependencies with undefined property expressions in their coordinates (groupId, artifactId, version)<properties>sections across the reactor (including profiles), skips well-known built-ins (project.*,env.*,settings.*,maven.*,revision,sha1,changelist, etc.)Editor.commentOutElement()with a<!-- mvnup: commented out - undefined property '...' -->marker for easy identification and reversalFixes #12080
Test plan
${project.version}) is preservedCompatibilityFixStrategyTesttests pass🤖 Generated with Claude Code
Claude Code on behalf of Guillaume Nodet