Consumer POM of multi-module project should exclude <build> and <dependencies> elements#11764
Merged
desruisseaux merged 1 commit intoapache:maven-4.0.xfrom Mar 27, 2026
Conversation
…ndencies> elements (apache#11639) * Move some of the codes needed by `ProjectSourcesHelper` in an utility class that we can reuse in other packages. * Consumer POM of multi-module project should exclude <build> and <dependencies> elements. * Add a test that verifies that `<build>` is preserved when `preserveModelVersion=true`. Co-authored-by: Gerd Aschemann <gerd@aschemann.net>
Contributor
Author
|
This is a backport of a change which was accepted on master three weeks ago. I tested again today after a rebase and saw no issue. I think that we can merge. This pull request is needed for allowing progress on apache/maven-jar-plugin#508. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #11639. It modifies the code that already exists in Maven core for deriving consumer POM. The modification consists in excluding
<build>and<dependencies>when the project is a multi-module project. The rational is explained in #11639. Note that for classical Maven projects, nothing change.