Log matching discovered toolchain as info in select-jdk-toolchain mojo#144
Log matching discovered toolchain as info in select-jdk-toolchain mojo#144HannesWell wants to merge 1 commit intoapache:masterfrom
Conversation
bb53645 to
bbc895f
Compare
There was a problem hiding this comment.
Maybe this should be in info level as it is final decision
There was a problem hiding this comment.
I think printing the final decision makes sense.
But with what's now all info I believe it might be a little bit too verbose for the standard log level case.
My suggestion would be to either have this an info or
What I like about the latter two is that one can derive from the printout the origin of the toolchain.
On the other hand, the former is more clear that it's the final decision (especially after I've adjusted the printout a bit).
To get the best from both world, we could add a variable that captures the origin and prints it as part of the final decision message.
There was a problem hiding this comment.
This one is also information about final decision
There was a problem hiding this comment.
Yes, this should be an info too especially as it 'diverts' from what one would expect from the preceding printout.
bbc895f to
fba8816
Compare
Fixes #141
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.