Skip to content

Log matching discovered toolchain as info in select-jdk-toolchain mojo#144

Open
HannesWell wants to merge 1 commit intoapache:masterfrom
HannesWell:log-discovered-toolchain-as-info
Open

Log matching discovered toolchain as info in select-jdk-toolchain mojo#144
HannesWell wants to merge 1 commit intoapache:masterfrom
HannesWell:log-discovered-toolchain-as-info

Conversation

@HannesWell
Copy link
Copy Markdown

Fixes #141

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@HannesWell HannesWell force-pushed the log-discovered-toolchain-as-info branch from bb53645 to bbc895f Compare March 10, 2026 22:56
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be in info level as it is final decision

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think printing the final decision makes sense.
But with what's now all info I believe it might be a little bit too verbose for the standard log level case.
My suggestion would be to either have this an info or

What I like about the latter two is that one can derive from the printout the origin of the toolchain.
On the other hand, the former is more clear that it's the final decision (especially after I've adjusted the printout a bit).
To get the best from both world, we could add a variable that captures the origin and prints it as part of the final decision message.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is also information about final decision

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be an info too especially as it 'diverts' from what one would expect from the preceding printout.

@HannesWell HannesWell force-pushed the log-discovered-toolchain-as-info branch from bbc895f to fba8816 Compare March 24, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print info about finally selected toolchain

2 participants