[1.9.x] Honor system proxy credentials in HTTP transport - #2149
Open
goutamadwant wants to merge 1 commit into
Open
goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
Backport proxy-scoped system credential fallback under the existing opt-in. Preserve explicit Resolver authentication precedence and clear system proxy authentication state when redirects change the proxy route. Adapt transfer, CONNECT, origin-isolation and redirect regressions to the Java 8 and Jetty 9 test harness. Fixes apache#2139.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2139.
Backport the system proxy credential fix to Resolver 1.9.x, the lineage used by the reported Maven 3.9.16 installation. With
aether.connector.http.useSystemProperties=true, matchinghttp.proxyUser/http.proxyPasswordorhttps.proxyUser/https.proxyPasswordcan authenticate the configured proxy when explicit Resolver authentication is unavailable.Keep fallback credentials separate from repository authentication and clear them when redirects change proxy or become direct. The default configuration and public API remain unchanged. Tests use the maintenance branch's JUnit 4 and Jetty 9 harness, with a test-only Jetty proxy dependency for HTTPS CONNECT.
The native regression fails with HTTP 407 on unchanged 1.9.x. Validation:
mvn verify: all 18 modules passed; 1,053 tests, zero failures/errors, one existing skip.mvn -Prun-its verify: passed, including 36 integration tests and one Invoker build.Full reactor builds used Java 21 and Maven 3.9.16; the additional HTTP test run used Java 8u504.
mvn verifypassed.mvn -Prun-its verifypassed.