Fail clearly when configureLocator has no project POM #275 - #299
Open
AzazelSensei wants to merge 1 commit into
Open
Fail clearly when configureLocator has no project POM #275#299AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
configureLocator ran outside the execute try/finally and called project.getFile().getParentFile() without a null check. Move it inside the guarded block and throw MojoExecutionException when the project has no POM file.
elharo
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).configureLocator()ran before thetry/finallythat restores the context classloader, and it calledproject.getFile().getParentFile()with no null check.Moved the call into that block. If the project has no POM file, throw
MojoExecutionExceptioninstead of a raw NPE.