test: add integration test for modular processor with shared dependencies#1042
Conversation
3ff2838 to
bb5a9ab
Compare
bb5a9ab to
f8a6fd1
Compare
|
I think that the analysis is correct and this pull request seems to address the issue, but as a workaround. Ideally, it seems to me that the issue should be addressed in Maven core or in Maven resolver. It would allow to add only the dependencies that were really requested, instead of adding all dependencies that could potentially have been requested. I was hopping that apache/maven#11380 would help, but maybe it is only a first step. If I'm guessing correctly (I have not yet verified with a step-by-step debugging), the above-cited PR 11380 fixes the type of transitive dependencies when the type is only |
|
Yes, it is. Using same GAV with different types is no-go currently. |
So, it is correct to said that apache/maven#11805 tries to make that possible? |
|
For information, I verified that when using Maven 4.1.0-SNAPSHOT with the apache/maven#11805 patch applied, the test provided in this pull request passes with not need to change anything in the compiler code (i.e. with |
|
Actually, instead of closing it, I was thinking to just discard the changes in |
…cies Regression test for apache#1039. The fix belongs in Maven core (apache/maven#11805).
73eaaec to
1cc7927
Compare
|
Done. |
|
I pushed a |
Integration test for #1039.
The underlying issue (same GAV with different types resolved to a single path) is being fixed in Maven core via apache/maven#11805. This PR adds a regression test only — no compiler plugin code changes.