fix: keep relative timestamps on just now for the first minute - #3364
Draft
Astro-Han wants to merge 1 commit into
Draft
fix: keep relative timestamps on just now for the first minute#3364Astro-Han wants to merge 1 commit into
Astro-Han wants to merge 1 commit into
Conversation
Sidebar and other RelativeTime rows were counting seconds under one minute, which made the suffix flicker. Hold a single just-now label until the minute boundary, and only refresh then. Generated-by: Maka
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relative-time suffixes under one minute were counting seconds (
1秒钟前,2秒钟前, …), which made sidebar task rows and otherRelativeTimesurfaces flicker. Keep a single just-now label (刚刚/just now) for the whole first minute, then switch to minute buckets, and delay the ticker until that boundary.Verification
packages/corebuild +node --test dist/__tests__/relative-time.test.js(pass)biome format/biome linton the touched files (pass)AI use
Select exactly one:
Tool(s) and scope:
Maka implemented the formatter/ticker change, tests, and this PR.
Checklist
Does this PR entail a change in behavior?