fix(desktop): reconcile goal arm across reconnects - #3363
Open
Sun-GLiang wants to merge 2 commits into
Open
Conversation
Generated-by: Codex
7 tasks
Sun-GLiang
marked this pull request as ready for review
August 21, 2026 01:51
hqhq1025
reviewed
Aug 21, 2026
hqhq1025
left a comment
Contributor
There was a problem hiding this comment.
Codex-assisted review performed under the maintainer-approved review workflow.
Generated-by: Codex
hqhq1025
approved these changes
Aug 21, 2026
hqhq1025
left a comment
Contributor
There was a problem hiding this comment.
The previous reconciliation-wait finding is fixed on this revision. The deadline is limited to replacement waits after a dispatched control enters reconciliation, expiry removes the waiter and returns the control-specific unavailable result, and goal.arm is not replayed. Exact-head build:test, the Desktop suite (996 tests), Desktop typecheck, lint, and format checks passed.
Codex-assisted review performed under the maintainer-approved review workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goal.arm, comparing canonical Goal state after a dispatched connection loss without replaying the mutation.Fixes #3234
Verification
npm test -w @maka/runtime-host— 1036 passednpm test -w @maka/desktop— 995 passednpm run typecheck -w @maka/desktop— passednpm run format:check— passednpm run lint— passednpm run e2e -w @maka/desktop -- goal-dialog-budget.spec.ts— 1 passedReview focus
AI use
Select exactly one:
Tool(s) and scope: Codex implemented the Desktop reconciliation seam, Goal integration, renderer behavior, tests, conflict resolution, and verification under user direction.
Checklist
Does this PR entail a change in behavior?