docs(windows-sandbox): align RFC guarantees with the shipped preview slice - #3152
docs(windows-sandbox): align RFC guarantees with the shipped preview slice#3152liugddx wants to merge 1 commit into
Conversation
…s later gates The AppContainer preview shipped in apache#2961 (merged 2026-08-17) enforces a subset of the RFC v1 guarantees. The RFC still stated three of them in the present tense that the shipped slice does not implement: - §6.3 private desktop / window-station isolation - §6.4 full production-identity readiness probe (the preview registers the backend on verified presence of the packaged native resource and fails closed if absent) - §6.4 launcher signature/version verification (the per-launch request digest is enforced in-broker today; binary signature/version verification is tied to Phase 3 signing) Mark each as an explicit later gate inline and add §6.5 "Preview implementation status" enumerating what the slice enforces vs what is deferred, so the RFC does not overclaim while keeping the fail-closed invariant intact: an unavailable/drifted/failed backend still fails closed and a restricted managed profile never falls back to host execution. Mirrored in the zh-CN RFC. Advances apache#2142 Phase 4 checkbox: align RFC guarantees with the shipped slice. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📝 WalkthroughSummary
Problem solvedThe RFC previously did not accurately describe the shipped AppContainer preview. This PR aligns the documentation with the current implementation and distinguishes enforced preview behavior from deferred capabilities. Source of truthThis PR extends the existing Windows Sandbox RFC in both supported languages. It does not create a parallel implementation or documentation path. Scope and complexityThis is the smallest coherent solution. It changes only two RFC files and adds no code, APIs, tests, or runtime paths. The added status section is necessary to document the preview boundary and release gates. Deletions or simplificationsNo code or tests can be deleted because this PR contains no code or test changes. The documentation consolidates preview guarantees and deferred capabilities without weakening behavior or regression coverage. Risks and validation
Review-relevant risksNo protected-area effect was identified in the current diff. The person performing the merge must review the final diff, and a maintainer makes the final determination. WalkthroughThe English and Chinese Windows sandbox RFCs now record the merged preview slice, its enforced isolation guarantees, deferred controls, and continued fail-closed requirements. ChangesWindows sandbox RFC
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: 🔵 Low · up to The docs-only change is mergeable with explicit owner follow-up to clarify the preview’s digest and launcher-verification boundaries, execution scope, and UI controls; no runtime behavior or production configuration is changed. Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Aligns the Windows sandbox RFC v1 (English + zh-CN) with the actually shipped Windows AppContainer “preview slice” from #2961 by explicitly marking several previously-presented guarantees as deferred “later gates,” and by adding a dedicated preview-status subsection to prevent the RFC from overclaiming.
Changes:
- Update the RFC header status to reference the #2961 preview slice merge and point readers to the new preview-scope section.
- Mark private-desktop isolation, full production-identity readiness probing, and launcher signature/version verification as deferred later gates.
- Add a new “Preview implementation status” subsection (§6.5) enumerating what the preview enforces vs. what is deferred.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/architecture/windows-sandbox-rfc-v1.md | Adds §6.5 preview scope + rephrases §6.3/§6.4 guarantees as later gates to match shipped slice behavior. |
| docs/architecture/windows-sandbox-rfc-v1.zh-CN.md | Mirrors the same RFC-scope alignment in zh-CN, including §6.5 and “later gate” annotations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - 状态：实现基线已选定；首个预览切片（[#2961](https://github.com/maka-agent/maka-agent/pull/2961)）已于 2026-08-17 合并；产品接入继续做发布验证（预览范围见 §6.5） | ||
| - 跟踪：[Issue #2142](https://github.com/maka-agent/maka-agent/issues/2142) Windows Phase 4 | ||
| - 更新日期：2026-08-14 | ||
| - Owner：`@maka/runtime` sandbox boundary 与 Runtime Host execution composition |
| - Status: implementation baseline selected; first preview slice ([#2961](https://github.com/maka-agent/maka-agent/pull/2961)) merged 2026-08-17; product integration continuing under release validation (preview scope in §6.5) | ||
| - Tracking: Windows Phase 4 in [issue #2142](https://github.com/maka-agent/maka-agent/issues/2142) | ||
| - Updated: 2026-08-14 | ||
| - Owners: `@maka/runtime` sandbox boundary and Runtime Host execution composition |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: a11df006-8c69-412d-87cd-426c371d3a47
📒 Files selected for processing (2)
docs/architecture/windows-sandbox-rfc-v1.mddocs/architecture/windows-sandbox-rfc-v1.zh-CN.md
Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review.
| - Launcher signature, version, and digest are verified against packaged metadata. _(Later gate: the | ||
| per-launch request digest is recomputed and enforced in-broker today; verifying the launcher | ||
| binary's signature and version against packaged metadata is deferred with Phase 3 signing — see | ||
| §6.5.)_ |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Use one precise digest contract in both RFCs.
The broker enforces a per-launch request digest. Launcher binary signature/version verification against package metadata is a separate deferred gate. (github.com)
docs/architecture/windows-sandbox-rfc-v1.md#L170-L173: separate request-digest enforcement from deferred signature/version verification.docs/architecture/windows-sandbox-rfc-v1.zh-CN.md#L138-L138: make the same distinction in Chinese.
📍 Affects 2 files
docs/architecture/windows-sandbox-rfc-v1.md#L170-L173(this comment)docs/architecture/windows-sandbox-rfc-v1.zh-CN.md#L138-L138
Source: MCP tools
| The first product slice — the packaged Windows 11 x64 AppContainer backend in | ||
| [#2961](https://github.com/maka-agent/maka-agent/pull/2961), merged 2026-08-17 — enforces a subset | ||
| of the guarantees above. This subsection aligns the documented guarantees with what the preview | ||
| actually ships so the RFC does not overclaim. The remaining guarantees are designed but explicitly | ||
| deferred as later gates, tracked by Phase 4 in [#2142](https://github.com/maka-agent/maka-agent/issues/2142). |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Keep the preview execution scope consistent across both RFCs.
#2961 limits the shipped slice to the packaged Windows 11 x64 Runtime filesystem-worker preview and excludes general-command/W2. (github.com)
docs/architecture/windows-sandbox-rfc-v1.md#L182-L186: add the filesystem-worker-only and no-general-command/W2 qualifier.docs/architecture/windows-sandbox-rfc-v1.zh-CN.md#L144-L146: add the same execution-scope qualifier in Chinese.
📍 Affects 2 files
docs/architecture/windows-sandbox-rfc-v1.md#L182-L186(this comment)docs/architecture/windows-sandbox-rfc-v1.zh-CN.md#L144-L146
Source: MCP tools
|
Superseded by #3161. Per reviewer feedback this slice should not ship as a standalone docs change — the RFC alignment is now folded into a real code PR (#3161) that implements the production-identity readiness probe ( |
What
Documentation-only alignment of the Windows sandbox RFC v1 (EN + zh-CN) with the AppContainer preview slice shipped in #2961 (merged 2026-08-17).
RFC v1 stated three guarantees in the present tense that the shipped slice does not implement. This PR marks each as an explicit later gate and adds a new §6.5 "Preview implementation status" that enumerates what the slice enforces vs. what is deferred — so the RFC no longer overclaims.
Marked as later gates (previously stated as shipped)
Invariant preserved
Deferral narrows readiness richness and desktop-layer defense-in-depth, not the enforcement boundary: an unavailable / drifted / failed backend still fails closed, and a restricted managed profile never falls back to host execution.
Why
Keeps the RFC honest about the preview scope while the remaining Phase 4 gates land, and closes the #2142 Phase 4 checkbox:
This PR takes the "mark them explicitly as later gates" path.
Scope
docs/architecture/windows-sandbox-rfc-v1.mddocs/architecture/windows-sandbox-rfc-v1.zh-CN.mdDocs-only. No code, tests, or build surface touched.
Refs #2142 (Phase 4 — RFC alignment)