[Azure Blobs] Forward chunk_size in download_object_as_stream#2169
Merged
Conversation
download_object_as_stream and download_object_range_as_stream passed the hardcoded AZURE_DOWNLOAD_CHUNK_SIZE to iter_content instead of the caller's chunk_size, so a requested size was silently ignored. Forward chunk_size (falling back to the default when None), matching the S3 driver. Adds a regression test covering both methods.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #2169 +/- ##
=======================================
Coverage 83.39% 83.39%
=======================================
Files 351 351
Lines 81504 81519 +15
Branches 8747 8747
=======================================
+ Hits 67967 67982 +15
Misses 10744 10744
Partials 2793 2793
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Azure Blobs] Forward chunk_size in download_object_as_stream
Description
Closes #1698.
download_object_as_streamanddownload_object_range_as_streamin the Azure Blobs driver passed the hardcodedAZURE_DOWNLOAD_CHUNK_SIZEtoiter_contentinstead of the caller'schunk_size, so a requested size was silently ignored. Both now forwardchunk_size(falling back to the default whenNone), matching the S3 driver's behavior.Status
Checklist (tick everything that applies)