[SERVER] Close sessions for terminated engine applications - #7755
Open
moelhoussein wants to merge 1 commit into
Open
moelhoussein wants to merge 1 commit into
moelhoussein wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When an engine application terminates, operations can fail with a generic transport error even though Kyuubi already knows the application has stopped.
This patch reports the application details, interrupts pending RPCs, and closes the session when the application state is
FAILED,KILLED, orFINISHED. Ambiguous states such asNOT_FOUNDkeep the existing transport-error behavior.How was this patch tested?
Both suites passed: 2/2 and 15/15 tests.
Also ran
dev/reformatandgit diff --check.Was this patch assisted by generative AI tooling?
Assisted-by: Cursor with GPT-5.6 Sol