Conversation
Signed-off-by: Denis Krivenko <dnskrv88@gmail.com>
wangzhigang1999
left a comment
wangzhigang1999
left a comment
There was a problem hiding this comment.
Non-blocking; otherwise looks good. Built the documentation locally and checked the rendered pages.
|
|
||
| 1. kyuubi-spark-sql-engine-{{ release }}_2.12.jar, the engine jar deployed with a Kyuubi distribution | ||
| 2. A copy of Spark distribution | ||
| 3. `kyuubi-spark-connector-tpch-<release>_2.12.jar`, which can be found in the [Maven Central](https://repo1.maven.org/maven2/org/apache/kyuubi/kyuubi-spark-connector-tpch_2.12/) |
There was a problem hiding this comment.
Could we preserve {{ release }} here and in the spark.jars example below, as in tpcds.md? The 1.12.0 documentation renders the matching version in both places. Keeping the substitution would preserve this behavior after the format migration.
There was a problem hiding this comment.
Nice catch, thanks!
I've fixed it:
There was a problem hiding this comment.
In fact, we should use kyuubi-spark-sql-engine_2.12-1.13.0-SNAPSHOT.jar instead of kyuubi-spark-sql-engine-1.13.0-SNAPSHOT_2.12.jar. There are similar issues elsewhere in the doc, should we update them all together? Note: the PMC changed this once before, see: c3edb02
Signed-off-by: Denis Krivenko <dnskrv88@gmail.com>
This branch has not been deployed
3 participants
Why are the changes needed?
The changes are needed to unify the format used for documentation, as described in the issue #7434.
The PR does not change page contents (only very minimal adjustments) to ensure an easier review of the migration.
The pages contain out-of-date information and broken links, requiring a comprehensive review and updates in a separate PRs.
How was this patch tested?
Tested by building the documentation and comparing the pages against the live site.
Was this patch assisted by generative AI tooling?
Assisted-by: Qwen Coder