Allow configuring base docker image in DockerfileMojo (#2785) - #2839
Open
Alwaysgaurav1 wants to merge 1 commit into
Open
Allow configuring base docker image in DockerfileMojo (#2785)#2839Alwaysgaurav1 wants to merge 1 commit into
Alwaysgaurav1 wants to merge 1 commit into
Conversation
- Add configurable 'image' parameter to DockerfileMojo defaulting to eclipse-temurin:11-jre - Add DockerfileMojoTest covering default and custom configurations - Strengthen test-dockerfile IT verification - Update developer documentation with image and command parameters and fix XML typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2785
Changes:
@Parameterimage(defaulting toeclipse-temurin:11-jre) inDockerfileMojo.javaso assemblies targeting Java 17+ or custom runtimes can specify their base image.DockerfileMojoTest.javaunit test suite covering default and custom configurations.test-dockerfileintegration test verification inverify.bsh.karaf-maven-plugin.adocdocumentation to describeimageandcommandparameters, and fix an XML closing tag typo (<goal>docker</goal>).