KAFKA-16499: Make client metrics cache eviction test deterministic - #23041
Open
lh0156 wants to merge 1 commit into
Open
KAFKA-16499: Make client metrics cache eviction test deterministic#23041lh0156 wants to merge 1 commit into
lh0156 wants to merge 1 commit into
Conversation
Wait for asynchronous reaper work with Kafka test utilities instead of a fixed preemptive timeout and polling sleep. Generated-by: OpenAI Codex (GPT-5)
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The client metrics cache eviction tests use a 300 ms preemptive timeout and a fixed 50 ms polling sleep while the SystemTimerReaper executes expiration tasks asynchronously. Under normal CI scheduling, the test can time out even though the timer task is progressing.
This change replaces the timing-sensitive loop with a shared wait helper based on Kafka's TestUtils.waitForCondition. The helper waits until both the timer queue and the expected client instances are drained, preserving the existing post-eviction metric and connection-map assertions.
Tests
./gradlew :server:test --tests org.apache.kafka.server.ClientMetricsManagerTest./gradlew :server:spotlessCheck :server:checkstyleTestgit diff --checkJira: https://issues.apache.org/jira/browse/KAFKA-16499