GH-4230: Add GeoSPARQL 1.1 geometryN function - #4231
Open
edmondchuc wants to merge 1 commit into
Open
edmondchuc wants to merge 1 commit into
edmondchuc wants to merge 1 commit into
Conversation
Add one-based direct member selection through geof:geometryN and GeometryWrapper, retaining the selected member's datatype, SRS and layout. Validate numeric indices and report invalid selections as expression errors. Preserve empty members in GML results and dimensional markers in WKT. Reject empty homogeneous Multi-geometry members that Jena's WKT reader cannot round-trip rather than silently discarding them. Include member-selection, serialization and Z/M regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #4230
Adds the GeoSPARQL 1.1
geof:geometryNfunction, also available throughGeometryWrapper.getGeometryN(int).The index is one-based and selects direct members without flattening nested collections. For example,
geof:geometryN("MULTIPOINT ((1 2), (3 4))"^^geo:wktLiteral, 2)returns
POINT (3 4).Selected members retain their source datatype, SRS, and coordinate layout. Invalid indices raise an expression error.
This also prevents serialisation from silently dropping empty members. Where Jena's WKT reader cannot preserve them, the function reports an error.
Depends on #4222 for the coordinate-sequence fixes needed to preserve Z/M values. All tests should pass once this branch is rebased after #4222 merges.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.