Conversation
Wrap nested query builders in an optional subquery element instead of merging only their WHERE patterns, so SELECT variables are retained. Fixes apache#3707
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3707
Summary
addOptional(AbstractQueryBuilder)now wraps the nested builder as anOPTIONAL { SELECT ... WHERE ... }subquery viaElementSubQuery, instead of copying only its WHEREElementGroup.WhereQuadHolder.Problem
Adding a nested
SelectBuilderwithselect.addOptional(selectOptional)dropped the innerSELECTvariables and produced a flat optional BGP (reporter’s ORDER BY / subquery use case).Test plan
mvn -pl jena-querybuilder -Dtest=SelectBuilderTest#testAddOptionalNestedSelectBuilder test(reproduces issue Select clause disappear from where clause #3707 snippet; asserts nested SELECT and both triple patterns inside OPTIONAL)