GH-3647: Allow 'uploading all' when loading into the default graph - #4104
Merged
Conversation
…aph through fuseki
afs
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #3647
Pull request Description:
This PR resolves an issue where loading all files at once without setting a named graph would be blocked. The core change is here, where we make the statement that empty graph names are valid names.
The change here fixes a small issue that I ran acroess where the original code short circuits when
this.validateGraphNameis False, leaving the potential to miss the error fromthis.validateFiles. The logic leads to only one of two errors being shown. This is likely seen in the screenshot in the attached issue where, after clicking Upload All with no files, there should have been a second error shown.As for why this wasn't affecting single file uploads... It doesn't look like the named graph name is getting gated (it gets watched by this but submission isn't rejected) when going that route.
Example after this PR:
Screen.Recording.2026-07-28.at.11.56.34.PM.mov
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.