Skip to content

GH-3647: Allow 'uploading all' when loading into the default graph - #4104

Merged
afs merged 1 commit into
apache:mainfrom
ThomasThelen:issue_3647
Jul 30, 2026
Merged

GH-3647: Allow 'uploading all' when loading into the default graph#4104
afs merged 1 commit into
apache:mainfrom
ThomasThelen:issue_3647

Conversation

@ThomasThelen

@ThomasThelen ThomasThelen commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

GitHub issue resolved #3647

Pull request Description:

This PR resolves an issue where loading all files at once without setting a named graph would be blocked. The core change is here, where we make the statement that empty graph names are valid names.

The change here fixes a small issue that I ran acroess where the original code short circuits when this.validateGraphName is False, leaving the potential to miss the error from this.validateFiles. The logic leads to only one of two errors being shown. This is likely seen in the screenshot in the attached issue where, after clicking Upload All with no files, there should have been a second error shown.

As for why this wasn't affecting single file uploads... It doesn't look like the named graph name is getting gated (it gets watched by this but submission isn't rejected) when going that route.

Example after this PR:

Screen.Recording.2026-07-28.at.11.56.34.PM.mov

  • Tests are included.
  • Documentation change and updates are provided for the Apache Jena website
  • Commits have been squashed to remove intermediate development commit messages.
  • Key commit messages start with the issue number (GH-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.


See the Apache Jena "Contributing" guide.

@afs
afs merged commit 8dd6c3c into apache:main Jul 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fuseki UI : add data : error displayed for default graph

2 participants