JAMES-4201 Remove the password.nodelete webadmin access level - #3147
Open
chibenwa wants to merge 1 commit into
Open
JAMES-4201 Remove the password.nodelete webadmin access level#3147chibenwa wants to merge 1 commit into
password.nodelete webadmin access level#3147chibenwa wants to merge 1 commit into
Conversation
`password.nodelete` was introduced alongside `password.readonly` and never
released. It promised that such a credential "can read and create/modify data
but cannot delete", but the filter only compares the literal HTTP method, while
WebAdmin models plenty of destructive operations as POST or PUT:
- `POST /users/{username}?action=deleteData` and
`POST /domains/{domainName}?action=deleteData` erase user data through a task,
- `PUT /users/{username}` resets the password of an existing account, which is a
full account takeover,
- `PUT /domains/{domain}/aliases/{alias}` and the forward routes reroute mail.
Making the filter action-aware would only paper over this: on an administration
API where creating and updating is as destructive as deleting, "everything but
the DELETE verb" cannot be a privilege separation, merely a guard-rail against
mistyped `curl` commands - one that reads as a security boundary and is
documented as one.
So drop the level rather than keep a boundary we cannot honour.
quantranhong1999
approved these changes
Sep 3, 2026
Arsnael
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
password.nodeletewas introduced alongsidepassword.readonlyand never released. It promised that such a credential "can read and create/modify data but cannot delete", but the filter only compares the literal HTTP method, while WebAdmin models plenty of destructive operations as POST or PUT:POST /users/{username}?action=deleteDataandPOST /domains/{domainName}?action=deleteDataerase user data through a task,PUT /users/{username}resets the password of an existing account, which is a full account takeover,PUT /domains/{domain}/aliases/{alias}and the forward routes reroute mail.Making the filter action-aware would only paper over this: on an administration API where creating and updating is as destructive as deleting, "everything but the DELETE verb" cannot be a privilege separation, merely a guard-rail against mistyped
curlcommands - one that reads as a security boundary and is documented as one.So drop the level rather than keep a boundary we cannot honour.
password(full access) andpassword.readonly(GET/HEAD only) remain, the latter being sound since no WebAdmin GET route mutates state.Genuine partial privileges need an authenticated administrator identity and a per-route, per-parameter authorization model - neither of which WebAdmin has, and both of which belong in a reverse proxy in front of it rather than in a verb filter inside James. The documentation now says so instead of advertising a delete/no-delete separation.