JAMES-4150 Make Attachment Storage Optional for PostgreSQL Message Store

[omerfarukicen]

This PR introduces a configurable option to enable or disable attachment storage in the PostgreSQL mailbox implementation.

[omerfarukicen]

can you review CI pipeline?
Build Error
or while contacting Gradle Enterprise server at https://ge.apache.org/
javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

[Arsnael]

Sounds like a random CI issue, I restarted the build

[Arsnael]

Overall looks good to me thank you @omerfarukicen ! Can you just be careful with the unnecessary indents in the code though? Adds noise. Thanks :)

[Arsnael]

@omerfarukicen those errors though look related to me: https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2885/3/testReport/

Can you have a look please? Thanks :)

[chibenwa]

It looks related to the docker runner apparently

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.001 s <<< FAILURE! -- in org.apache.james.backends.postgres.PostgresTableManagerTest
org.apache.james.backends.postgres.PostgresTableManagerTest -- Time elapsed: 0.001 s <<< ERROR!
java.lang.NoClassDefFoundError: Could not initialize class org.apache.james.backends.postgres.PostgresTableManagerTest
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method)
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1160)
	at java.base/java.lang.reflect.Field.acquireOverrideFieldAccessor(Field.java:1200)
	at java.base/java.lang.reflect.Field.getOverrideFieldAccessor(Field.java:1169)
	at java.base/java.lang.reflect.Field.get(Field.java:444)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
	at java.base/java.util.stream.Sink$ChainedReference.end(Sink.java:261)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:510)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.NoClassDefFoundError: Could not initialize class org.apache.james.backends.postgres.PostgresExtension [in thread "main"]
	at org.apache.james.backends.postgres.PostgresTableManagerTest.<clinit>(PostgresTableManagerTest.java:41)
	... 16 more

I relaunched a build

[Arsnael]

Same errors, I believe related to the change

[omerfarukicen]

ors though look related to me

UnixSocketClientProviderStrategy: failed with exception BadRequestException (Status 400: {"message":"client version 1.32 is too old. Minimum supported API version is 1.44, please upgrade your client to a newer version

In the DockerPostgresSingleton class, the static initialization block starts the Docker container. If this initialization fails (for example, if Docker is not running or the image cannot be downloaded), the application fails during class loading. If we remove the static initialization block, the container will be started lazily in PostgresExtension.beforeAll().

[Arsnael]

My bad I did not read the logs deeper... That's weird, this is a bug between testcontainers and latest docker version (that I guess the Apache CI is using) and we did fix it a while back already. Like here: #2854

Not too sure what's going on then... I restarted a build, let's see

[chibenwa]

This work needs to be revised on master in order to get latest test container fixes

[chibenwa]

@omerfarukicen

The postgresql branch was a feature branch used while working on the pg backend. As the postgresql backend is merged in master, the given branch is no longer in use.

Could you rework this so that it targets master branch?

Thanks!

[omerfarukicen]

Just to confirm, should I rebase my current branch onto master and change the base of this PR to target master instead of the postgresql branch?

[Arsnael]

Just to confirm, should I rebase my current branch onto master and change the base of this PR to target master instead of the postgresql branch?

Yes indeed! Thanks a lot