Oak 2.0.0 plus fixes#2913
Draft
reschke wants to merge 2 commits into
Draft
Conversation
* don't write files which are already on disk * add unit-test
…ncy accurate (#2903) * OAK-12214 : segment cache: notify L2 on L1 hits to keep frequency/recency accurate L1 memoization in SegmentId serves most segment reads without touching L2. This means W-TinyLFU admission sketches and LRU recency lists never see hot segments, and the eviction policy treats them as cold — potentially evicting them under pressure. SegmentCache.recordHit(SegmentId) now calls cache.getIfPresent(id) to register the access with the L2 backing store. The behaviour is controlled by feature toggle FT_NOTIFY_L2_OAK-12214 (enabled by default). Also adds cleanUp() to flush pending Caffeine maintenance before reading eviction stats. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * OAK-12214 : notify L2 caffeine cache if we got a hit on L1 to keep its internal frequency updated such that we don't evict hot segments * OAK-12214 : removed cleanUp() method, not needed * OAK-12214 : write test cases to reproduce the behaviour consistently * OAK-12214 : addressed review comments * OAK-12214 : updated javadocs to reflect correct oak version * OAK-12214 : renamed FT --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(no intent to actually merge this, it's just for validation)