Fix WAL throttle threshold fallback on hot reload - #18514
Open
CRZbulabula wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick the upstream fix from merge commit 23201f2 (TimechoDB source: 519946c1a0).
When wal_throttle_threshold_in_byte is hot-reloaded from a positive value to a negative value, resolve the negative value to the configured default before updating IoTConsensus. Also expose the effective threshold through SHOW CONFIGURATION.
The cherry-pick conflicted in PropertiesTest because rc/2.0.11 has a different test history. The conflict was resolved by retaining the branch existing tests and adding the WAL regression test, plus the required ConfigurationFileUtils import.
Tests