Pipe: throttle TsFile parser retries under memory pressure#18141
Open
Caideyipi wants to merge 1 commit into
Open
Pipe: throttle TsFile parser retries under memory pressure#18141Caideyipi wants to merge 1 commit into
Caideyipi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
PR #18051 fixed a real self-blocking risk by releasing the TsFile parser when downstream tablet consumption hits
PipeRuntimeOutOfMemoryCriticalException. That fallback is still necessary: with many pipes, parser-side memory and parsed tablet memory can otherwise hold each other and stop progress.However, in scenarios such as 10 pipes with device-level pattern matching, a transient consumer-side OOM currently closes the parser immediately and retries the whole TsFile event later. This turns short memory pressure into repeated local TsFile reparsing, which is very expensive.
Changes
pipe_tsfile_parser_memory, so too many TsFile parsers will not run concurrently under memory pressure.Tests
mvn -pl iotdb-core/datanode -Dtest=TsFileInsertionEventParserTest#testConsumeTabletInsertionEventsWithRetryReleasesParserOnOutOfMemory+testConsumeTabletInsertionEventsWithRetryKeepsParserForTransientOutOfMemory -DforkCount=0 test