Pipe: disable serialize-by-region by default#18139
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default value of connector.serialize-by-region / sink.serialize-by-region to false, so the serialize-by-region sink behavior added in #17946 is opt-in by default.
It also updates related unit expectations so the default data-region sink remains the async IoTDB thrift sink, while explicitly enabling serialize-by-region still selects the sync sink and uses region-prefixed subtask attributes.
Tests
mvn -pl iotdb-core/datanode -Dtest=PipeDataNodePluginAgentTest,PipeSinkSubtaskManagerTest test -Ddevelocity.off=true, but it is blocked before running tests by existing datanode compile errors in generated/freemarker and queryengine/i18n sources, including missingIFill/IFillFilter, missingComparatorChain, missingAccumulator, and missingQueryMessagesconstants.