Skip to content

Limit repeated warning logs#17889

Open
Caideyipi wants to merge 12 commits into
masterfrom
fix-log-throttling
Open

Limit repeated warning logs#17889
Caideyipi wants to merge 12 commits into
masterfrom
fix-log-throttling

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Summary

  • log login lock messages only when thresholds are first reached
  • suppress duplicate auth attack and ConfigNode connection warnings while the same condition persists
  • throttle repeated disk free-space warnings per directory

Tests

  • mvn -Ddevelocity.off=true -nsu -pl iotdb-core/node-commons spotless:apply
  • mvn -Ddevelocity.off=true -nsu -pl iotdb-core/datanode spotless:apply
  • JUnitCore: org.apache.iotdb.commons.utils.JVMCommonUtilsTest
  • JUnitCore: org.apache.iotdb.db.auth.LoginLockManagerTest org.apache.iotdb.db.auth.AuthorizerManagerTest

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.41317% with 211 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.88%. Comparing base (611b66a) to head (b439db6).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...db/service/metrics/IoTDBInternalLocalReporter.java 28.78% 47 Missing ⚠️
...etrics/metricsets/net/WindowsNetMetricManager.java 0.00% 33 Missing ⚠️
.../metrics/metricsets/net/LinuxNetMetricManager.java 0.00% 24 Missing ⚠️
...e/manager/subscription/SubscriptionMetaSyncer.java 5.55% 17 Missing ⚠️
...torageengine/load/active/ActiveLoadDirScanner.java 39.28% 17 Missing ⚠️
...b/metrics/reporter/iotdb/IoTDBSessionReporter.java 17.64% 14 Missing ⚠️
.../apache/iotdb/db/auth/ClusterAuthorityFetcher.java 43.47% 13 Missing ⚠️
...trics/metricsets/disk/LinuxDiskMetricsManager.java 71.42% 12 Missing ⚠️
...ava/org/apache/iotdb/db/auth/LoginLockManager.java 91.22% 5 Missing ⚠️
...service/metrics/file/SystemRelatedFileMetrics.java 16.66% 5 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17889      +/-   ##
============================================
- Coverage     41.88%   41.88%   -0.01%     
- Complexity      318      387      +69     
============================================
  Files          5297     5299       +2     
  Lines        374168   374738     +570     
  Branches      48302    48378      +76     
============================================
+ Hits         156726   156964     +238     
- Misses       217442   217774     +332     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts:
#	iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/PipeMetaSyncer.java
#	iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/heartbeat/PipeHeartbeatScheduler.java
#	iotdb-core/datanode/src/test/java/org/apache/iotdb/db/conf/directories/strategy/DirectoryStrategyTest.java
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/disk/strategy/MinFolderOccupiedSpaceFirstStrategy.java
# Conflicts:
#	iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/subscription/SubscriptionMetaSyncer.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/impl/DataNodeInternalRPCServiceImpl.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/IoTDBInternalLocalReporter.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/generator/TsFileNameGenerator.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/WALManager.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/AbstractNodeAllocationStrategy.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/active/ActiveLoadDirScanner.java
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/disk/FolderManager.java
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/disk/strategy/MinFolderOccupiedSpaceFirstStrategy.java
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/JVMCommonUtils.java
#	iotdb-core/node-commons/src/test/java/org/apache/iotdb/commons/utils/JVMCommonUtilsTest.java
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant