Skip to content

[To dev/1.3] Pipe: Implemented batch logic for air-gap sink (#17667)#17727

Open
Caideyipi wants to merge 1 commit into
dev/1.3from
cp-air
Open

[To dev/1.3] Pipe: Implemented batch logic for air-gap sink (#17667)#17727
Caideyipi wants to merge 1 commit into
dev/1.3from
cp-air

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
10.7% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 53.02013% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.23%. Comparing base (1d35780) to head (8a6e69f).

Files with missing lines Patch % Lines
...ink/protocol/airgap/IoTDBDataRegionAirGapSink.java 54.86% 65 Missing ⚠️
...db/commons/pipe/sink/protocol/IoTDBAirGapSink.java 0.00% 3 Missing ⚠️
.../pipe/agent/task/subtask/sink/PipeSinkSubtask.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #17727      +/-   ##
=============================================
+ Coverage      42.10%   42.23%   +0.12%     
  Complexity       241      241              
=============================================
  Files           3613     3613              
  Lines         238749   238877     +128     
  Branches       29003    29019      +16     
=============================================
+ Hits          100531   100891     +360     
+ Misses        138218   137986     -232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant