Skip to content

feat: add compile-time i18n for log and exception messages #17613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JackieTien97 wants to merge 13 commits into
base: master
Choose a base branch
from

refactor: address i18n code review feedback

a2d4f0e
Select commit
Loading
Failed to load commit list.
Open

feat: add compile-time i18n for log and exception messages #17613

refactor: address i18n code review feedback
a2d4f0e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 16, 2026 in 7m 33s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 63 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/ICompactionSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4AToU43p748isTtjpE&open=AZ4AToU43p748isTtjpE&pullRequest=17613

Check warning on line 110 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/store/ProcedureFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4ATp-23p748isTtjqF&open=AZ4ATp-23p748isTtjqF&pullRequest=17613

Check warning on line 197 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/queryengine/execution/operator/source/relational/aggregation/grouped/hash/FlatGroupByHash.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4CjNnzLyVlc5HDnOzz&open=AZ4CjNnzLyVlc5HDnOzz&pullRequest=17613

Check warning on line 133 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/schema/SchemaUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 101). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4ATp3-3p748isTtjp9&open=AZ4ATp3-3p748isTtjp9&pullRequest=17613

Check warning on line 84 in library-udf/src/main/java/org/apache/iotdb/library/util/CircularQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'IllegalArgumentException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4B1nyt4MikHFVFI9qQ&open=AZ4B1nyt4MikHFVFI9qQ&pullRequest=17613

Check warning on line 108 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/utils/WALFileUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4AToZZ3p748isTtjpM&open=AZ4AToZZ3p748isTtjpM&pullRequest=17613

Check warning on line 1409 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/impl/DataNodeInternalRPCServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4CjP3bLyVlc5HDnO0J&open=AZ4CjP3bLyVlc5HDnO0J&pullRequest=17613

Check warning on line 78 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/protocol/opcua/client/ClientRunner.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4ATpPb3p748isTtjpu&open=AZ4ATpPb3p748isTtjpu&pullRequest=17613

Check warning on line 86 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/queryengine/plan/planner/plan/node/PlanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'UnsupportedOperationException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4AToCD3p748isTtjoe&open=AZ4AToCD3p748isTtjoe&pullRequest=17613

Check warning on line 163 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/quotas/DefaultOperationQuota.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'RuntimeException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4ATojk3p748isTtjpZ&open=AZ4ATojk3p748isTtjpZ&pullRequest=17613

Check warning on line 150 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/quotas/DataNodeThrottleQuotaManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the built-in formatting to construct this argument. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4AToj13p748isTtjpa&open=AZ4AToj13p748isTtjpa&pullRequest=17613

Check warning on line 674 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/TableHeaderSchemaValidator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'SemanticException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4ATotf3p748isTtjpj&open=AZ4ATotf3p748isTtjpj&pullRequest=17613

Check warning on line 468 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/queryengine/execution/operator/source/relational/aggregation/grouped/hash/FlatHash.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4CjNoGLyVlc5HDnOz0&open=AZ4CjNoGLyVlc5HDnOz0&pullRequest=17613

Check warning on line 3186 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/impl/ClientRPCServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4CjP5LLyVlc5HDnO0L&open=AZ4CjP5LLyVlc5HDnO0L&pullRequest=17613

Check warning on line 269 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/batch/utils/FollowingBatchCompactionAlignedChunkWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4AToQm3p748isTtjo3&open=AZ4AToQm3p748isTtjo3&pullRequest=17613

Check warning on line 87 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/agent/plugin/builtin/processor/throwing/ThrowingExceptionProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4CjNwZLyVlc5HDnOz-&open=AZ4CjNwZLyVlc5HDnOz-&pullRequest=17613

Check warning on line 623 in iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/plan/planner/TableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 85 to 64, Complexity from 21 to 14, Nesting Level from 3 to 2, Number of Variables from 15 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4B1mhg4MikHFVFI9qH&open=AZ4B1mhg4MikHFVFI9qH&pullRequest=17613

Check warning on line 240 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4ATpM93p748isTtjpt&open=AZ4ATpM93p748isTtjpt&pullRequest=17613

Check warning on line 98 in iotdb-client/cli/src/main/java/org/apache/iotdb/cli/utils/CliContext.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4ATqWs3p748isTtjqM&open=AZ4ATqWs3p748isTtjqM&pullRequest=17613

Check warning on line 301 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/TVList.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'UnsupportedOperationException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4CjQfoLyVlc5HDnO0O&open=AZ4CjQfoLyVlc5HDnO0O&pullRequest=17613

Check warning on line 85 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/writer/ReadPointInnerCompactionWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4AToRA3p748isTtjo7&open=AZ4AToRA3p748isTtjo7&pullRequest=17613

Check warning on line 65 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/util/ModsOperationUtil.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'PipeException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4ATpbi3p748isTtjpx&open=AZ4ATpbi3p748isTtjpx&pullRequest=17613

Check warning on line 57 in iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/GroupedLSBWatermarkEncoder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4ATqXH3p748isTtjqN&open=AZ4ATqXH3p748isTtjqN&pullRequest=17613

Check warning on line 80 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/writer/ReadPointInnerCompactionWriter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4AToRA3p748isTtjo6&open=AZ4AToRA3p748isTtjo6&pullRequest=17613

Check warning on line 82 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/columngenerator/parameter/ColumnGeneratorParameter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'else' construct must use '{}'s. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4CjQgBLyVlc5HDnO0R&open=AZ4CjQgBLyVlc5HDnO0R&pullRequest=17613
View more details on SonarQubeCloud