[codex] Keep thrift prebuilt artifacts under target#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prebuilt.artifacts.dirtotarget/prebuilt-artifacts.target/.iotdb-tools-thrift/prebuilt-artifacts/ignore entry so accidental use of that path is visible ingit status.Root Cause
The previous instructions downloaded prebuilt platform zip files into
iotdb-tools-thrift/prebuilt-artifacts/. The Apache parent source-release assembly scans the project directory and excludestarget/, but it does not exclude that top-level temporary directory. As a result, the source release zip included all prebuilt binary zips.Validation
./mvnw clean, then downloaded the workflow artifact totarget/prebuilt-artifactswithgh run download 27532371068 --repo apache/iotdb-bin-resources --name iotdb-tools-thrift-all-platforms --dir target/prebuilt-artifacts../mvnw package -P apache-release,prebuilt-artifacts -Dgpg.skip=truesuccessfully.target/iotdb-tools-thrift-0.23.0.0-source-release.zipis 78,369 bytes and contains noprebuilt-artifacts,target/, or nested zip entries.