Repository navigation
IGNITE-29211 Hot-reload TLS certificates automatically before expiry #13786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anton-vinogradov
wants to merge
413
commits into
apache:master
Choose a base branch
from
anton-vinogradov:ignite-29211
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,025
−32
Open
Changes from all commits
Commits
Show all changes
413 commits
Select commit
Hold shift + click to select a range
bfd9416
Merge branch 'ignite-29210' into ignite-29211
anton-vinogradov 6459a46
IGNITE-29209 Allow factory details in .NET SSL error assertions
anton-vinogradov 754cc1e
Merge branch 'ignite-29209' into ignite-29210
anton-vinogradov ee1c1e2
Merge branch 'ignite-29210' into ignite-29211
anton-vinogradov 71459c7
IGNITE-29210 Clarify SSL reload certificate checks
anton-vinogradov c35ec73
Merge branch 'ignite-29210' into ignite-29211
anton-vinogradov e9a90b4
IGNITE-29210 Wait for consistency cancellation status cleanup in tests
anton-vinogradov 6df7a90
Merge ignite-29210 into ignite-29211
anton-vinogradov ba1dbcf
IGNITE-29209 Let SSL factories own initialized bundles
anton-vinogradov 22e3ec5
IGNITE-29209 Clarify initialized factory lifetime
anton-vinogradov f3b80a0
IGNITE-29210 Reload the state owned by SSL factories
anton-vinogradov f869900
Merge branch 'ignite-29209' into ignite-29210
anton-vinogradov 4c35f32
IGNITE-29211 Renew the material owned by the SSL factory
anton-vinogradov 5a30822
Merge branch 'ignite-29210' into ignite-29211
anton-vinogradov f6b57b3
IGNITE-29209 Keep initialization tests and helpers within API scope
anton-vinogradov 9b80a43
IGNITE-29210 Remove test-only SSL provider context accessor
anton-vinogradov dec35ba
IGNITE-29211 Remove test-only SSL provider forwarding
anton-vinogradov de9fcf9
IGNITE-29210 Keep consistency cancellation fix in its own branch
anton-vinogradov c424767
IGNITE-29210 Merge reviewed factory initialization foundation
anton-vinogradov 34b1f7a
IGNITE-29211 Merge reviewed manual reload foundation
anton-vinogradov 79323d1
IGNITE-29211 Honor overridden SSL renewal settings
anton-vinogradov 19c2dd7
IGNITE-29209 Return accepted SSL context snapshots
anton-vinogradov 2eab286
IGNITE-29210 Keep SSL forwarding in the node provider
anton-vinogradov 4daf24c
IGNITE-29211 Merge snapshot factory and node SSL forwarding
anton-vinogradov f07e080
IGNITE-29209 Initialize key managers with loaded key material
anton-vinogradov 40b2d6e
IGNITE-29210 Merge initialized key material values
anton-vinogradov c1f2255
IGNITE-29211 Merge initialized key material values
anton-vinogradov 2589424
IGNITE-29209 Keep SSL bundle construction as a protected hook
anton-vinogradov ecdc378
IGNITE-29210 Use the protected SSL loading hook in tests
anton-vinogradov 69db941
IGNITE-29211 Use the protected SSL loading hook in tests
anton-vinogradov 1b17a46
IGNITE-29209 Clarify prepared key material hook contract
anton-vinogradov 16f815d
IGNITE-29210 Merge prepared key material hook documentation
anton-vinogradov 5c5aebe
IGNITE-29211 Merge prepared key material hook documentation
anton-vinogradov f77be52
IGNITE-29210 Simplify SSL test material and factory hooks
anton-vinogradov ea50365
IGNITE-29211 Test renewal through factories and snapshot status time
anton-vinogradov c5c8e48
IGNITE-29210 Document direct SSL bundle loading hooks
anton-vinogradov 3661fc3
IGNITE-29211 Adapt node test hooks to checked SSL loading
anton-vinogradov 06489a8
IGNITE-29209 Build SSL bundles directly from loaded stores
anton-vinogradov 4a7ce7c
Merge IGNITE-29209 direct bundle loading into IGNITE-29210
anton-vinogradov f5a9a6f
Merge IGNITE-29210 direct bundle loading into IGNITE-29211
anton-vinogradov d9fc2fc
IGNITE-29210 Use a clear certificate alias name in CLI test
anton-vinogradov 0e76a9d
Merge commit 'd9fc2fcea5309921293c1885fdf5b12aeb02ed0e' into ignite-2…
anton-vinogradov 756e613
IGNITE-29210 Add certificate generation dependency to CLI tests
anton-vinogradov a4bd1b1
Merge commit '756e613f719eb8a8d8cae44602c2b39f7848a4a6' into ignite-2…
anton-vinogradov f004af6
IGNITE-29209 Keep source parameter validation in the store factory
anton-vinogradov a566a35
Merge ignite-29209 parameter hook cleanup into ignite-29210
anton-vinogradov 7963fe0
Merge ignite-29210 parameter hook cleanup into ignite-29211
anton-vinogradov 07f3f4b
IGNITE-29210 Clarify custom factory validation migration
anton-vinogradov 820e07c
Merge ignite-29210 custom factory migration documentation
anton-vinogradov d58cd6a
IGNITE-29210 Reject SSL contexts that cannot supply TCP sockets
anton-vinogradov 8e36bc9
IGNITE-29211 Validate the renewal window and discard attempts during …
anton-vinogradov 215240a
Merge branch 'ignite-29210' into ignite-29211
anton-vinogradov c20c22e
IGNITE-29209 Limit explicit TLS initialization to factory subclasses
anton-vinogradov dfe2f48
IGNITE-29210 Keep factory snapshot and reload access inside the node
anton-vinogradov b8980a0
IGNITE-29211 Use internal factory snapshots when planning TLS renewal
anton-vinogradov 3f915d6
IGNITE-29210 Keep reload diagnostics inside the node and report provi…
anton-vinogradov 6bca809
IGNITE-29209 Preserve keyless client factories and document snapshot use
anton-vinogradov a9e61a8
IGNITE-29210 Remove the obsolete connector import
anton-vinogradov 7c5984e
Merge IGNITE-29209 compatibility and migration changes into manual re…
anton-vinogradov 048e40e
IGNITE-29210 Keep reconnect test independent of certificate generation
anton-vinogradov f4e1d28
IGNITE-29211 Keep renewal inside the node and verify its lifecycle
anton-vinogradov ff4573a
Merge reviewed manual TLS reload into IGNITE-29211
anton-vinogradov 500089e
IGNITE-29209 Clarify custom TLS configuration and context reads
anton-vinogradov 11c0b8c
IGNITE-29210 Merge factory documentation and explain reload checks on…
anton-vinogradov eee3041
IGNITE-29211 Count certificate source failures while renewal is running
anton-vinogradov 79dfcce
Merge commit '11c0b8cda272bb1a498bceb00b66e8b0c7281607' into ignite-2…
anton-vinogradov 96ff5ef
Merge branch 'ignite-29209' into ignite-29210
anton-vinogradov 0983f4c
IGNITE-29209 Verify that concurrent SSL reloads publish in order
anton-vinogradov e57a63a
IGNITE-29210 Cover preinitialized factories at transport registration
anton-vinogradov 3560648
Merge branch 'ignite-29209' into ignite-29210
anton-vinogradov 6822aa5
IGNITE-29209 Shorten SSL factory hook Javadoc
anton-vinogradov 1eff18f
Merge commit '3560648c' into ignite-29211
anton-vinogradov 6a6cb7d
IGNITE-29210 Distinguish initial load retries from TLS replacement
anton-vinogradov 5888cb2
IGNITE-29211 Clarify renewal settings and make the node test wait for…
anton-vinogradov 63019fa
Merge commit '6a6cb7d0' into ignite-29211
anton-vinogradov dcb1e82
IGNITE-29211 Keep renewal tests focused on configured settings
anton-vinogradov bafc004
IGNITE-29211 Remove unused test mock import
anton-vinogradov 32bee26
IGNITE-29211 Check renewal with an interrupted source thread
anton-vinogradov de80327
Merge remote-tracking branch 'refs/remotes/apache-r8/master' into ign…
anton-vinogradov 38394c2
Merge branch 'ignite-29209' into ignite-29210
anton-vinogradov 7b1c2fb
IGNITE-29209 Clarify custom SSL factory material and protocol require…
anton-vinogradov f45312f
IGNITE-29210 Clarify reload requirements and bound failure timestamps
anton-vinogradov 3fc01c6
Merge commit 'f45312f5f481b22653f5fc93bc70e6488fb7f972' into ignite-2…
anton-vinogradov 6b6cb10
Merge branch 'ignite-29209' into ignite-29210
anton-vinogradov e29bfc9
IGNITE-29209 Mark the key password array nullable
anton-vinogradov a3a3d48
Merge commit '6b6cb108a00a0048f0a09c9ce77eb85617e33e8a' into ignite-2…
anton-vinogradov a8d6d1f
IGNITE-29209 Limit explicit factory initialization to the SSL context
anton-vinogradov aacfde5
Merge remote-tracking branch 'refs/remotes/apache-init-minimal/master…
anton-vinogradov c4a9441
IGNITE-29209 Remove unused SSLContext import
anton-vinogradov 4410ba4
IGNITE-29209 Check the initialization exception directly
anton-vinogradov fbff93f
IGNITE-29209 Retain the protected SSL context cache
anton-vinogradov 7d9331f
IGNITE-29209 Keep the first fix scoped to explicit SSL context reload
anton-vinogradov b86cc22
IGNITE-29209 Narrow the explicit SSL initialization contract
anton-vinogradov ef19a92
IGNITE-29209 Test SSL cache overrides separately
anton-vinogradov 460d6b3
IGNITE-29209 Pause SSL init at key store open in test
anton-vinogradov 99917c9
IGNITE-29209 Test the outcomes of explicit SSL initialization
anton-vinogradov 0d8a872
IGNITE-29209 Drop the direct SSL cache mutation test
anton-vinogradov 0a4d83a
Merge remote-tracking branch 'refs/remotes/apache/master' into ignite…
anton-vinogradov c108148
IGNITE-29256 Use the current SSL context for new TCP connections
anton-vinogradov 7ae2081
IGNITE-29256 Keep Javadoc focused on transport changes
anton-vinogradov 34da982
IGNITE-29256 Simplify added Javadoc
anton-vinogradov bca5874
IGNITE-29256 Remove unnecessary line breaks
anton-vinogradov 1bc5dad
IGNITE-29256 Simplify discovery SSL socket handling
anton-vinogradov d654ae8
IGNITE-29256 Verify ordinary discovery factories retain their context
anton-vinogradov 3d9112b
IGNITE-29256 Simplify SSL factory wiring
anton-vinogradov d697adb
IGNITE-29256 Prepare REST protocol filters before port retries
anton-vinogradov ea0071a
IGNITE-29256 Use the current context from every SSL factory
anton-vinogradov 7674cb5
IGNITE-29256 Preserve SSL filter call formatting
anton-vinogradov 9b89ee0
IGNITE-29256 Reuse discovery SSL enablement flag
anton-vinogradov 77d95c5
IGNITE-29256 Use the SSL context factory directly in discovery
anton-vinogradov 3b7d641
IGNITE-29256 Remove redundant discovery comments
anton-vinogradov c71769a
IGNITE-29256 Validate discovery SSL with an unconnected socket
anton-vinogradov cc1a169
IGNITE-29256 Keep startup SSL validation focused on socket creation
anton-vinogradov 490abbe
IGNITE-29256 Explain startup SSL socket validation
anton-vinogradov 722fe71
IGNITE-29256 Use a single SSL filter constructor
anton-vinogradov 50ae47e
IGNITE-29256 Pass SSL factories directly and refresh thin-client conn…
anton-vinogradov dc3852e
IGNITE-29256 Pass the thin client SSL factory directly to NIO
anton-vinogradov 9d04c90
IGNITE-29256 Preserve discovery retries and count early SSL rejections
anton-vinogradov 46a0f4f
IGNITE-29256 Make TLS test scenarios explicit
anton-vinogradov f6cefca
IGNITE-29256 Use current timeout API in SSL tests
anton-vinogradov 9755920
IGNITE-29256 Drop unnecessary SSL test settings
anton-vinogradov ea65b2d
IGNITE-29256 Separate NIO recovery and rejection tests
anton-vinogradov 0cc3ef1
IGNITE-29256 Clarify SSL factory recovery test name
anton-vinogradov d8e6fcb
IGNITE-29256 Test SSL factory failure during filter creation
anton-vinogradov d78f07c
IGNITE-29256 Make discovery test connection actions explicit
anton-vinogradov 36cffbd
IGNITE-29256 Keep one SSL factory in discovery recovery test
anton-vinogradov 6258a8d
IGNITE-29256 Simplify SSL test setup and recovery scope
anton-vinogradov 1eff48f
IGNITE-29256 Exercise factory init in discovery protocol tests
anton-vinogradov fbbf2bb
IGNITE-29256 Name shared TLS test data
anton-vinogradov 7cb02e2
IGNITE-29256 Make TLS test inputs and expectations explicit
anton-vinogradov d3135f8
IGNITE-29256 Separate TLS reload test scenarios
anton-vinogradov 22430ea
IGNITE-29256 Focus TLS tests on transport guarantees
anton-vinogradov 1c357c3
IGNITE-29256 Test REST recovery after occupied port
anton-vinogradov 983c238
IGNITE-29256 Handle discovery TLS errors at connection boundary
anton-vinogradov b0562e9
IGNITE-29256 Explain eager SSL context initialization
anton-vinogradov a00342f
IGNITE-29256 Preserve thin client SSL startup failures
anton-vinogradov a5e18ba
IGNITE-29210 Add manual TLS reload command
anton-vinogradov 27077f6
IGNITE-29210 Cover missing targets and clarify reload guidance
anton-vinogradov 542e17d
IGNITE-29210 Clarify completed reload results
anton-vinogradov 4a9b887
IGNITE-29210 Remove redundant test import
anton-vinogradov 8ab8e74
Merge commit '5d4ff8f299ed5266675bf4f4b0cc64c3d7aa74ef' into ignite-2…
anton-vinogradov 374c3ed
IGNITE-29210 Register TLS factories in TCP SPIs
anton-vinogradov cd315d0
IGNITE-29210 Use a plain SSL factory registry
anton-vinogradov 2bf7dc1
IGNITE-29210 Add SSL reload result wire description
anton-vinogradov 2beeb77
IGNITE-29210 Improve reload diagnostics and tests
anton-vinogradov 9f2c2d9
IGNITE-29210 Simplify reload command tests
anton-vinogradov 3588e69
IGNITE-29210 Clarify HTTP REST reload scope
anton-vinogradov fa21b1b
IGNITE-29210 Clarify reload documentation
anton-vinogradov 2faa3bb
IGNITE-29210 Keep factory Javadoc focused on behavior
anton-vinogradov 11dcd39
IGNITE-29210 Drop unrelated trust manager Javadoc change
anton-vinogradov 0cb438a
IGNITE-29210 Remove redundant comments
anton-vinogradov bcc52e5
IGNITE-29210 Test TLS reload when a node leaves before replying
anton-vinogradov f979dde
IGNITE-29210 Simplify node departure test and reload documentation
anton-vinogradov 405b249
IGNITE-29210 Separate unsupported factory and reload failure tests
anton-vinogradov 86035ce
IGNITE-29210 Coordinate initial SSL loading with reload
anton-vinogradov eeb4aa5
IGNITE-29210 Stop node TLS reload on first failure
anton-vinogradov 1c59af4
IGNITE-29210 Test cached context access during reload
anton-vinogradov f151b87
IGNITE-29211 Restart renewal implementation on accepted manual reload
anton-vinogradov 8f81912
Merge current Apache master for IGNITE-29211
anton-vinogradov 0f2a8df
Merge Apache master with accepted IGNITE-29210
anton-vinogradov 21b7baa
IGNITE-29211 Renew TLS certificates before expiry
anton-vinogradov 285bdd3
IGNITE-29211 Isolate renewal from the reload caller context
anton-vinogradov 5757400
IGNITE-29211 Coordinate TLS renewal in the registry
anton-vinogradov 529f552
IGNITE-29211 Cover renewal recovery and shutdown
anton-vinogradov be30769
IGNITE-29211 Keep renewal cancellation inside factory
anton-vinogradov 73e75d8
IGNITE-29211 Serialize renewal operations on the scheduler
anton-vinogradov 33ea1c8
IGNITE-29211 Publish renewal dates after a successful load
anton-vinogradov 5c0f0a8
IGNITE-29211 Cancel a waiting renewal through thread interruption
anton-vinogradov e5f996c
IGNITE-29211 Fix renewal startup ordering and expiry checks
anton-vinogradov 997e016
IGNITE-29211 Explain certificate renewal as an operating procedure
anton-vinogradov bf5ed26
IGNITE-29211 Clarify renewal skips and failure contracts
anton-vinogradov 65e136f
IGNITE-29211 Explain manual reload outcomes and recovery options
anton-vinogradov d24c9ac
IGNITE-29211 Wait one hour after reloading certificates already due f…
anton-vinogradov 16441e8
IGNITE-29211 Validate replacements and report unchanged TLS material
anton-vinogradov 5d4ac0c
IGNITE-29211 Fail renewal attempts that leave certificates due
anton-vinogradov 51a1e00
IGNITE-29211 Preserve renewal retry ordering during startup
anton-vinogradov 1288607
IGNITE-29211 Fix IDEA warnings in TLS renewal
anton-vinogradov 03b2a53
IGNITE-29211 Rely on executor publication for registry fields
anton-vinogradov f61dce5
IGNITE-29211 Keep renewal dependencies in each renewal
anton-vinogradov 779e7f8
IGNITE-29211 Keep one failure counter per renewal
anton-vinogradov 0256992
IGNITE-29211 End the failure streak where renewal is scheduled
anton-vinogradov d6d724b
IGNITE-29211 Load manual reloads on the caller thread
anton-vinogradov cedc548
IGNITE-29211 Separate replacement checks from renewal time
anton-vinogradov a6cf69f
IGNITE-29211 Return the stored renewal time
anton-vinogradov bbe71df
IGNITE-29211 Check certificate dates on every load
anton-vinogradov 705dbe4
IGNITE-29211 Renew without a separate factory lock
anton-vinogradov c68b577
IGNITE-29211 Stop renewal by the registry executor
anton-vinogradov f07d9e9
IGNITE-29211 Keep reload and renewal scheduling in one queue
anton-vinogradov 2d176c9
IGNITE-29211 Make SSL key store loading explicit
anton-vinogradov c95b5c2
Revert "IGNITE-29211 Make SSL key store loading explicit"
anton-vinogradov f2d0501
IGNITE-29211 Build the SSL context from a local key store
anton-vinogradov 0d957f7
Revert "IGNITE-29211 Build the SSL context from a local key store"
anton-vinogradov e791554
IGNITE-29211 Check each renewal rule in one test
anton-vinogradov 3edbc43
IGNITE-29211 Pass the loaded key store explicitly
anton-vinogradov 55a8e04
IGNITE-29211 Keep the key store chains in the key managers
anton-vinogradov 469e0e9
IGNITE-29211 Pass the key store chains next to the key managers
anton-vinogradov 59bdf80
IGNITE-29211 Make the key chains holder a record
anton-vinogradov d1e5979
IGNITE-29211 Load the key store explicitly in SslContextFactory
anton-vinogradov f922ebc
IGNITE-29211 Read the key chains from the key store of createKeyManag…
anton-vinogradov 617a617
IGNITE-29211 Drop test settings that the checks do not need
anton-vinogradov a46a167
IGNITE-29211 Name renewal tests after what they check
anton-vinogradov 03ca0fa
IGNITE-29211 State renewal test conditions in each test
anton-vinogradov d0bbeb8
IGNITE-29211 Check renewal of due certificates on a node
anton-vinogradov cd5bd0e
IGNITE-29211 Rename certificate renewal to hot reload
anton-vinogradov f36c843
IGNITE-29211 Keep the loaded key store local to context creation
anton-vinogradov 0945312
IGNITE-29211 Restore the hot reload date when context loading fails
anton-vinogradov 2ae403c
IGNITE-29211 Keep the hot reload date readable during loading
anton-vinogradov 51195d9
IGNITE-29211 Leave certificate validity decisions to TLS peers
anton-vinogradov 1cebe8e
IGNITE-29211 Wait for the hot reload failure log in the node test
anton-vinogradov fbba10d
IGNITE-29211 Test the registry with factories over key store files
anton-vinogradov 7a9fbad
IGNITE-29211 Cover the remaining hot reload rules in tests
anton-vinogradov 8d523d9
IGNITE-29211 Check reload command with hot reload and warn about notB…
anton-vinogradov 396fd3b
IGNITE-29211 Preserve hot reload at epoch and clarify recovery
anton-vinogradov f02ca02
IGNITE-29211 Calculate hot reload time directly from key store
anton-vinogradov a596c05
IGNITE-29211 Test registry start and early reload with real factories
anton-vinogradov a0adc8c
IGNITE-29211 Schedule automatic reload with an explicit empty context
anton-vinogradov 9406caa
IGNITE-29211 Separate hot reload test scenarios
anton-vinogradov 71797be
IGNITE-29211 Give each hot reload rule its own test
anton-vinogradov c834405
IGNITE-29211 Describe what each hot reload test checks
anton-vinogradov 155fe04
IGNITE-29211 Start each test description with its guarantee
anton-vinogradov 3e0578f
IGNITE-29211 Describe hot reload tests as Given, When, Then
anton-vinogradov 7224f6b
IGNITE-29211 Cover reload failures and stabilize timing tests
anton-vinogradov 8c1efb1
IGNITE-29211 Exercise supported hot reload flows and remove redundant…
anton-vinogradov fb4fdac
IGNITE-29211 Remove synthetic hot reload startup test
anton-vinogradov a5cfeb9
IGNITE-29211 Drop unreachable stop check from hot reload start
anton-vinogradov 6104e3e
IGNITE-29211 Start hot reload a fixed time before expiry and retry ho…
anton-vinogradov 8ea5180
IGNITE-29211 Name the first-load test by its guarantee
anton-vinogradov 97e3f8f
IGNITE-29211 Name the hot reload lead time setting with its unit
anton-vinogradov d76513f
IGNITE-29211 Warn instead of failing when no key gives a hot reload date
anton-vinogradov 15ff080
IGNITE-29211 Drop the special case for a zero hot reload date
anton-vinogradov 28b930d
IGNITE-29211 Do not wait for the hot reload thread on node stop
anton-vinogradov 33df749
IGNITE-29211 Group transports by factory before starting hot reload
anton-vinogradov 36a5713
IGNITE-29211 Check hot reload every hour instead of scheduling each a…
anton-vinogradov 4d54ac5
IGNITE-29211 Run manual reloads in the caller thread
anton-vinogradov 816df2c
IGNITE-29211 Remove test helpers left from scheduled attempts
anton-vinogradov 9cb2826
IGNITE-29211 Group transports by factory once, in the registry
anton-vinogradov 55f2502
IGNITE-29211 Map each registered factory to its transports
anton-vinogradov 68ef92e
IGNITE-29211 Name registered transports and grouped factories by what…
anton-vinogradov 3465458
IGNITE-29211 Stop checks on node stop, reset failures when no longer …
anton-vinogradov fe6e10c
IGNITE-29211 Fix hot reload dates for Windows stores and saved factories
anton-vinogradov a30430c
IGNITE-29211 Reload each TLS factory instance and clarify retry timing
anton-vinogradov 9950ca3
IGNITE-29211 Use standard entries for registered TLS factories
anton-vinogradov d34e62a
IGNITE-29211 Log the hot reload date used for the decision and verify…
anton-vinogradov 60b69fc
IGNITE-29211 Remove custom SslContextFactory deserialization
anton-vinogradov 3621858
IGNITE-29211 Trim the change to what hot reload needs
anton-vinogradov 8e63f3a
IGNITE-29211 Keep hot reload wrappers in a list and find them by refe…
anton-vinogradov ea46663
IGNITE-29211 Keep every registered factory in one list of wrappers
anton-vinogradov 0d4d317
IGNITE-29211 Say that manual reload works on registered factories
anton-vinogradov d87d131
IGNITE-29211 Derive hot reload from the factory instead of a wrapper …
anton-vinogradov 541872e
IGNITE-29211 Rename SslFactoryWrapper to RegisteredFactory
anton-vinogradov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.