Conversation
# Conflicts: # modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/IgniteSchema.java
zstan
reviewed
Sep 23, 2026
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 3
Open (16)
deleteDirectorycurrently returnsfalseeven on success becauseresis initialized tofalse… · NewdeleteDirectorycurrently returnsfalseeven on success becauseresis initialized tofalse… · NewdeleteDirectorycurrently returnsfalseeven on success becauseresis initialized tofalse… · Newdis not used when streaming data;streamer.addData(i, i)repeatedly writes… · NewtoLowerCase()without an explicit locale can produce surprising results in… · NewtoLowerCase()without an explicit locale can produce surprising results in… · NewtoLowerCase()without an explicit locale can produce surprising results in… · NewIgniteCheckedException, but the new “delete in… · NewUNSURED_DELETION_PREFshould… · NewG.allGrids();is a no-op statement here (return value is ignored, and it has no side effects). It… · New
Resolved since last review (9)
null, the default snapshots root, and an equivalent…deletePhasetreats an empty path as the default…snapshotsRoot: values…deletePhase, after this call has broadcast an…serverNodes(topVer), not baseline nodes, anddeletePhase…
zstan
reviewed
Sep 24, 2026
|
|
||
| /** */ | ||
| public String snapshotName() { | ||
| return snapshotName; |
Contributor
There was a problem hiding this comment.
It`s not about arg processing, it about @Nullable annotation
| * @return {@code True}, if data is found and completely deleted; | ||
| * {@code False}, if nothing found or if data is found but might not be deleted completely. | ||
| */ | ||
| public boolean deleteLocalSnapshot(SnapshotFileTree sft, @Nullable AtomicBoolean existsFlag) { |
Contributor
There was a problem hiding this comment.
I question about atomic - you reply about lambda and final )
Seems this complication cause you want return
IgniteSnapshotManager#deleteLocalSnapshot 2 states here, from return mechanism and from AtomicBoolean state, overcomplicated, change it plz
| * proceeds if snapshot already deleted. | ||
| */ | ||
| @Test | ||
| public void testConcurrentSnapshotDeleteOperation() throws Exception { |
Contributor
There was a problem hiding this comment.
From java doc: "Tests that snapshot create detects concurrent deletion", but i see that it tests only already existing snap ? Seems this test is not cover conc deletion opertion, other conc tests need to be re checked too
Contributor
Author
There was a problem hiding this comment.
This test does cover concurrent snapshot creation operation which cannot start. Of course, we create cnapshot. With an unexisting snapshot the deletion doesn't start at all - the metas aren't found. There will be no cuncurrency, The opposite tests (when deletion cannot start) are in IgniteClusterSnapshotDeleteTest. For example, testSnapshotDeleteWhenCreateInProgress.
Contributor
There was a problem hiding this comment.
For concurrent delete with create operations I expect the different err message here?
Contributor
Author
There was a problem hiding this comment.
The messages are different. Actually, snapshot creation a bit differs from other snp. operations. First things first, it checks snp. existence. But only on the node where the process starts. Also, there is the same isSnapshotDeleting() check in the first stage of the creation routine within its DP (initLocalSnapshotStartStage), near the other checks.
… into IGNITE-29050-Introduce-snapshot-deletion-command
zstan
reviewed
Sep 25, 2026
|
|
||
| /** */ | ||
| @RunWith(Parameterized.class) | ||
| public class IgniteClusterSnapshotDeleteTest extends AbstractSnapshotSelfTest { |
Contributor
There was a problem hiding this comment.
plz add test where you create 2 snaps in different cases, i.e. snap and snAp and check for deletion all of them?
Contributor
Author
There was a problem hiding this comment.
I realized I need a case-insensitive filesystem. I'll return to this question later.
zstan
reviewed
Sep 25, 2026
zstan
reviewed
Sep 25, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Request identity and absent-node calculation currently produce incorrect concurrency blocking and operator warnings.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (6)
Resolved since last review (17)
deleteDirectorycurrently returnsfalseeven on success becauseresis initialized tofalse…deleteDirectorycurrently returnsfalseeven on success becauseresis initialized tofalse…deleteDirectorycurrently returnsfalseeven on success becauseresis initialized tofalse…deletePhase, after this call has broadcast an…IgniteCheckedException, but the new “delete in…toLowerCase()without an explicit locale can produce surprising results in…toLowerCase()without an explicit locale can produce surprising results in…toLowerCase()without an explicit locale can produce surprising results in…dis not used when streaming data;streamer.addData(i, i)repeatedly writes…G.allGrids();is a no-op statement here (return value is ignored, and it has no side effects). It…UNSURED_DELETION_PREFshould…
|
|
||
| var curCreateRq = snpMgr.currentCreateRequest(); | ||
|
|
||
| if (curCreateRq != null && curCreateRq.snpName.equalsIgnoreCase(req.snpName)) { |
Comment on lines
+75
to
+80
| return Objects.equals(resolvedPath, other.resolvedPath); | ||
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public int hashCode() { | ||
| return Objects.hash(resolvedPath); |
Comment on lines
+318
to
+319
| # Delete the snapshot "snapshot_09062021" located in the "/tmp/ignite/snapshots" folder. | ||
| control.bat --snapshot delete snapshot_09062021 --src /tmp/ignite/snapshots |
Possible compatibility issues. Please, check rolling upgrade casesThis PR modifies protected classes (with Order annotation). Affected files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.