IGNITE-28851 Embedded Ignite Features to Serialization Mechanism for transport between Ignite nodes - #13532
IGNITE-28851 Embedded Ignite Features to Serialization Mechanism for transport between Ignite nodes#13532petrov-mg wants to merge 3 commits into
Conversation
8f88913 to
f1f55e7
Compare
19aed5d to
5390be6
Compare
69ba88a to
2fd54ff
Compare
petrov-mg
changed the title
7b46247 to
bba0352
Compare
| */ | ||
| @Retention(RetentionPolicy.CLASS) | ||
| @Target(ElementType.TYPE) | ||
| public @interface RollingUpgradeAware { |
There was a problem hiding this comment.
How about a bit different name: RollingUpgradeSubject? To me the word "Aware" has a semantics close to "I receive some information about the process I'm aware of" rather than "I'm a key participant of the process of Rolling Upgrade"
There was a problem hiding this comment.
I renamed it to @FeatureGated - it emphasizes that the class fields are coupled with corresponding features, which are in turn taken into account during RU.
| import org.apache.ignite.internal.processors.rollingupgrade.feature.IgniteFeature; | ||
|
|
||
| /** | ||
| * Marks a class whose serialization takes the Rolling Upgrade into account. |
There was a problem hiding this comment.
I suggest to improve documentation of this class.
If a developer modifies a message in a way that should support RU, he/she will have to use this annotation anyway.
We need to make the javadoc as clear as possible to explain to the developer how to use it and what role in a bigger picture the annotation plays.
…transport between Ignite nodes
0d5bc25 to
7714e17
Compare
7714e17 to
6fa9ed1
Compare
Possible compatibility issues. Please, check rolling upgrade casesThis PR modifies protected classes (with Order annotation). Affected files:
|
2 participants
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.