IGNITE-28833 Add system views for cache locks#13347
Open
alex-plekhanov wants to merge 2 commits into
Open
Conversation
alex-plekhanov
force-pushed
the
ignite-28833
branch
4 times, most recently
from
04d8918 to
5bbed69
Compare
alex-plekhanov
force-pushed
the
ignite-28833
branch
from
5bbed69 to
2b73fba
Compare
nizhikov
reviewed
Jul 10, 2026
| } | ||
|
|
||
| /** */ | ||
| public String enabledFlags() { |
Contributor
There was a problem hiding this comment.
Let's create separate column for each flag, instead of complex string creation that will lead to gc pressure.
nizhikov
reviewed
Jul 10, 2026
| getInteger(IGNITE_MAX_NESTED_LISTENER_CALLS, DFLT_MAX_NESTED_LISTENER_CALLS); | ||
|
|
||
| /** System view name for cache explicit locks. */ | ||
| public static final String CACHE_EXPLICIT_LOCKS_VIEW = "cacheExplicitLocks"; |
Contributor
There was a problem hiding this comment.
metricName("cache", "explicit", "locks")
Contributor
Author
There was a problem hiding this comment.
metricName returns "cache.explicit.locks", not "cacheExplicitLocks"
nizhikov
reviewed
Jul 10, 2026
| public static final String CACHE_EXPLICIT_LOCKS_VIEW_DESC = "Explicit locks on cache keys"; | ||
|
|
||
| /** System view name for cache locks. */ | ||
| public static final String CACHE_KEY_LOCKS_VIEW = "cacheKeyLocks"; |
Contributor
There was a problem hiding this comment.
metricName("cache", "key", "locks")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.