feat(sdk): implement vsr header framing#3254
Open
numinnex wants to merge 15 commits into
Open
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (24.04%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3254 +/- ##
============================================
- Coverage 73.80% 70.93% -2.88%
Complexity 943 943
============================================
Files 1200 1200
Lines 109116 104565 -4551
Branches 86006 81472 -4534
============================================
- Hits 80535 74175 -6360
- Misses 25853 27458 +1605
- Partials 2728 2932 +204
🚀 New features to boost your workflow:
|
Contributor
|
/ready |
hubcio
requested changes
May 20, 2026
Contributor
hubcio
left a comment
There was a problem hiding this comment.
notes on items that did not fit a line range:
- the
IggyNamespace::newmasking issue (namespace.rs:108-113) is upstream and not touched by this PR, but the SDK now feeds raw wire u32s straight into it (vsr.rs:187), so the silent-collision blast radius lands inside this PR. would be good to range-check at the SDK boundary even if the namespace fix lands separately. send_raw_with_responseretry at tcp_client.rs:136-148 is pre-existing, but the newreset_vsr_session()calls at lines 548/567 turn the retry path into a silent recovery failure whenauto_login=Disabled: reset clears the bound session,connect()skips re-login, nextsend_rawencodes with session=None and returnsUnauthenticatedfor what looks like a transient transport error. consider gating retry onsession.is_bound()under vsr, or forcingauto_loginon under vsr.#[cfg(feature = "vsr")]is interleaved per-line acrosscore/sdk/src/{tcp,quic,websocket}/*.rs(8 separate gates in tcp_client.rs alone). consider extractingsend_legacy/send_vsrhelpers per transport, or splitting the vsr framing into its own module, to reduce mis-edit hazard.
Contributor
Author
|
@hubcio made a commit that addresses issues from those comments |
Contributor
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Vsrfeature flag in thesdkcrate that introduces the consensus header required by the requests.Additionally adds one
hello_worldtest that tests thelogincommand using the new integration test suite adapted toserver-ngbinary.