refactor(connectors): extract row-processing logic into reusable process_row method#3198
Merged
krishvishal merged 3 commits intoMay 20, 2026
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3198 +/- ##
=============================================
- Coverage 74.18% 18.36% -55.83%
Complexity 943 943
=============================================
Files 1200 1191 -9
Lines 109618 94753 -14865
Branches 86508 71780 -14728
=============================================
- Hits 81323 17401 -63922
- Misses 25548 76953 +51405
+ Partials 2747 399 -2348
🚀 New features to boost your workflow:
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR. Thank you for your contribution! |
Contributor
|
/ready |
hubcio
approved these changes
May 20, 2026
krishvishal
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3173
Rationale
Row-processing logic lived inline in
poll_tables, making it impossible to reuse across future parallel/chunked polling paths without duplication.What changed?
The column-iteration, value-extraction, JSON-payload construction, and
ProducedMessageassembly were tightly coupled insidepoll_tables's inner loop (~80 lines). Any new polling variant (parallel, chunked) would need to copy-paste this block.Extracted a
process_rowmethod that accepts aRowProcessingConfig(table, tracking/pk columns, format flags) and returns aProcessedRow(message + offset + pk). Thepoll_tablesloop now delegates to this single-responsibility method in ~12 lines.Local Execution
AI Usage