Core: Preserve trailing slash on table location in V4 manifest reader - #17807
Open
anoopj wants to merge 1 commit into
Open
Core: Preserve trailing slash on table location in V4 manifest reader#17807anoopj wants to merge 1 commit into
anoopj wants to merge 1 commit into
Conversation
The V4 manifest reader stripped a trailing slash from the table location before resolving relative file locations against it. Remove the strip as it should be done by the catalog during table creation - it is not the reader's responsibility
uros-b
approved these changes
Aug 25, 2026
Member
|
LGTM |
Member
|
I'm not sure I agree on the rationale, but I do think that we should be using table location as is here. If the stored value has an additional slash we should be using it at this point. I |
RussellSpitzer
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The V4 manifest reader stripped a trailing slash from the table location before resolving relative file locations against it. Remove the strip as it should be done by the catalog during table creation and not the reader's responsibility.