Core: Stop remote planning workers when ScanTaskIterable closes - #17803
Open
yangshangqing95 wants to merge 1 commit into
Open
Core: Stop remote planning workers when ScanTaskIterable closes#17803yangshangqing95 wants to merge 1 commit into
yangshangqing95 wants to merge 1 commit into
Conversation
singhpk234
reviewed
Aug 25, 2026
singhpk234
left a comment
singhpk234
left a comment
Contributor
There was a problem hiding this comment.
seems like there is already a pr for this : #16768
may be please coordinate with the author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop local remote-planning workers when
ScanTaskIterableis closed by setting the shutdown flag and clearing pending tasks.ScanTasksIteratordelegates to the same close path.Tests
Added a regression test that closes the iterable during an in-flight fetch and verifies workers exit without fetching additional plan tasks.