OpenAPI: Add snapshot encryption key ID - #17800
Open
yangshangqing95 wants to merge 1 commit into
Open
Conversation
singhpk234
reviewed
Aug 24, 2026
yangshangqing95
force-pushed
the
fix/add-key-id-in-openapi
branch
from
August 24, 2026 20:52
2447e19 to
5f7b6a3
Compare
yangshangqing95
force-pushed
the
fix/add-key-id-in-openapi
branch
from
August 24, 2026 20:54
5f7b6a3 to
d29f5e8
Compare
Contributor
|
This change LGTM, i believe we can start quick vote for this, this seems like just a spec miss to me SnapshotParser already supports it : https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/SnapshotParser.java#L56 |
singhpk234
approved these changes
Aug 24, 2026
uros-b
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the optional
key-idfield to the OpenAPISnapshotschema and regenerates the Python models.This preserves manifest list encryption key IDs in generated clients while remaining compatible with snapshots that do not use encryption.